Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 9688003: aura: Fix segfault when launching aura_demo on Linux. (Closed)

Created:
8 years, 9 months ago by tfarina
Modified:
8 years, 9 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

aura: Fix segfault when launching aura_demo on Linux. BUG=117255 R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126202

Patch Set 1 #

Patch Set 2 : StackingClientImpl #

Total comments: 2

Patch Set 3 : DemoStackingClient #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M ui/aura/demo/demo_main.cc View 1 2 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
8 years, 9 months ago (2012-03-11 18:12:04 UTC) #1
Ben Goodger (Google)
why is p NULL? On Sun, Mar 11, 2012 at 11:12 AM, <tfarina@chromium.org> wrote: > ...
8 years, 9 months ago (2012-03-11 23:48:37 UTC) #2
tfarina
On Sun, Mar 11, 2012 at 8:48 PM, Ben Goodger (Google) <ben@chromium.org> wrote: > why ...
8 years, 9 months ago (2012-03-11 23:53:02 UTC) #3
Ben Goodger (Google)
can we do that in the demo instead? -Ben On Sun, Mar 11, 2012 at ...
8 years, 9 months ago (2012-03-11 23:54:07 UTC) #4
tfarina
On 2012/03/11 23:54:07, Ben Goodger (Google) wrote: > can we do that in the demo ...
8 years, 9 months ago (2012-03-12 00:08:02 UTC) #5
Ben Goodger (Google)
lgtm http://codereview.chromium.org/9688003/diff/2004/ui/aura/demo/demo_main.cc File ui/aura/demo/demo_main.cc (right): http://codereview.chromium.org/9688003/diff/2004/ui/aura/demo/demo_main.cc#newcode75 ui/aura/demo/demo_main.cc:75: class StackingClientImpl : public aura::client::StackingClient { DemoStackingClient (a ...
8 years, 9 months ago (2012-03-12 16:35:33 UTC) #6
tfarina
8 years, 9 months ago (2012-03-12 17:36:04 UTC) #7
http://codereview.chromium.org/9688003/diff/2004/ui/aura/demo/demo_main.cc
File ui/aura/demo/demo_main.cc (right):

http://codereview.chromium.org/9688003/diff/2004/ui/aura/demo/demo_main.cc#ne...
ui/aura/demo/demo_main.cc:75: class StackingClientImpl : public
aura::client::StackingClient {
On 2012/03/12 16:35:33, Ben Goodger (Google) wrote:
> DemoStackingClient (a la DemoWindowDelegate, above)

Done.

Powered by Google App Engine
This is Rietveld 408576698