BuildBucket-based build triggering

scripts/master/buildbucket/__init__.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """buildbucket module implements buildbucket-buildbot integration.
 
 The main entry point is buildbucket.setup() that accepts master configuration
 dict with other buildbucket parameters and configures master to run builds
 scheduled on buildbucket service.
 
 Example:
   buildbucket.setup(
       c,  # Configuration object.
       ActiveMaster,
       buckets=['qo'],
   )
 
 """
 
 import functools
 import os
 
 from .common import Error
 from .integration import BuildBucketIntegrator
 from .poller import BuildBucketPoller
 from .status import BuildBucketStatus
 from . import client
+from . import trigger

[ghost stip (do not use), 2015/03/04 23:07:30]

have we always used relative imports here? seems weird

[nodir, 2015/03/04 23:52:09]

I understand why using absolute imports is better: if your the importing modules
moves, all imports would have to be modified. This is not the case for
inseparable files, like all files in the buildbucket module. They are likely to
be moved together than independently.

 
 
 def setup(
     config, active_master, buckets, poll_interval=10,
     buildbucket_hostname=None, max_lease_count=None, verbose=None,
     dry_run=None):
   """Configures a master to lease, schedule and update builds on buildbucket.
 
   Requires config to have 'mergeRequests' set to False.
 
@@ skipping 32 matching lines @@
   poller = BuildBucketPoller(
       integrator=integrator,
       poll_interval=poll_interval,
       dry_run=dry_run)
   status = BuildBucketStatus(
       integrator,
       buildbucket_service_factory=buildbucket_service_factory,
       dry_run=dry_run)
   config.setdefault('change_source', []).append(poller)
   config.setdefault('status', []).append(status)