Issue 9677065: ash: Update app list UI to match latest crwm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9677065: ash: Update app list UI to match latest crwm. (Closed)

Created:
8 years, 9 months ago by xiyuan

Modified:
8 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Update app list UI to match latest crwm. - Tile app list item horizontally; - Move item title to the bottom; - Update padding for model view: 45px from left/right and 32px from top/bottom; - Change shade from 0.4 black to 0.2 black; - Update animation; - Defer app list widget activation until showing animation is finished; BUG=117238, 117073 TEST=Verify fix for issue 117238. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126665

Patch Set 1 #

Patch Set 2 : fix win_aura #

Patch Set 3 : rebase #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -135 lines)			Patch
M	ash/app_list/app_list.h	View		3 chunks	+10 lines, -7 lines	0 comments	Download
M	ash/app_list/app_list.cc	View	1 2	7 chunks	+50 lines, -33 lines	0 comments	Download
M	ash/app_list/app_list_item_view.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	ash/app_list/app_list_item_view.cc	View		4 chunks	+25 lines, -17 lines	0 comments	Download
M	ash/app_list/app_list_model_view.h	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	ash/app_list/app_list_model_view.cc	View		4 chunks	+38 lines, -67 lines	0 comments	Download
M	ash/app_list/app_list_view.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	ash/app_list/app_list_view.cc	View	1	6 chunks	+36 lines, -4 lines	0 comments	Download
A	ui/gfx/transform_util.h	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	ui/gfx/transform_util.cc	View		1 chunk	+19 lines, -0 lines	0 comments	Download
A	ui/gfx/transform_util_unittest.cc	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/ui_unittests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/9677065/4002

8 years, 9 months ago (2012-03-14 04:26:57 UTC) #3

commit-bot: I haz the power

8 years, 9 months ago (2012-03-14 06:57:53 UTC) #4

Can't apply patch for file ash/app_list/app_list.cc.
While running patch -p1 --forward --force;
patching file ash/app_list/app_list.cc
Hunk #3 FAILED at 51.
1 out of 7 hunks FAILED -- saving rejects to file ash/app_list/app_list.cc.rej

Expand Messages | Collapse Messages