Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 9677043: Debugger: add ability to set script source from within OnBeforeCompile. (Closed)

Created:
8 years, 9 months ago by pfeldman
Modified:
8 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Debugger: add ability to set script source from within OnBeforeCompile.

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Debugger: add ability to set script source from within OnBeforeCompile. #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1 line) Patch
M src/compiler.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/factory.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/mirror-debugger.js View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 4 3 chunks +12 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
A test/mjsunit/debug-set-script-source.js View 1 2 3 4 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pfeldman
8 years, 9 months ago (2012-03-13 15:33:42 UTC) #1
yurys
https://chromiumcodereview.appspot.com/9677043/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/9677043/diff/1/src/runtime.cc#newcode12560 src/runtime.cc:12560: // Patches script source (should be called upon BeforeCompile ...
8 years, 9 months ago (2012-03-13 17:09:30 UTC) #2
pfeldman
> We should check here that the script source is not changed after BeforeCompile. I ...
8 years, 9 months ago (2012-03-13 17:47:21 UTC) #3
pfeldman
8 years, 9 months ago (2012-03-13 17:47:46 UTC) #4
Søren Gjesse
lgtm Regarding only changing the script source in OnBeforeCompile you could add a flag to ...
8 years, 9 months ago (2012-03-14 09:49:26 UTC) #5
Yang
On 2012/03/14 09:49:26, Søren Gjesse wrote: > lgtm > > Regarding only changing the script ...
8 years, 9 months ago (2012-03-14 10:30:30 UTC) #6
pfeldman
> Regarding only changing the script source in OnBeforeCompile you could add a > flag ...
8 years, 9 months ago (2012-03-14 14:06:04 UTC) #7
Yang
8 years, 9 months ago (2012-03-14 14:14:20 UTC) #8
LGTM with one comment.

https://chromiumcodereview.appspot.com/9677043/diff/12001/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/9677043/diff/12001/src/runtime.cc#newc...
src/runtime.cc:12284: script->set_source(*source);
Not sure if silent failure is the best thing to do. Maybe return
isolate->ThrowIllegalOperation()?

Powered by Google App Engine
This is Rietveld 408576698