Debugger: add ability to set script source from within OnBeforeCompile.

Debugger: add ability to set script source from within OnBeforeCompile.

[yurys, 2012-03-13 17:09:30]

https://chromiumcodereview.appspot.com/9677043/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/9677043/diff/1/src/runtime.cc#newcode1...
src/runtime.cc:12560: // Patches script source (should be called upon
BeforeCompile event).
We should check here that the script source is not changed after BeforeCompile.

[pfeldman, 2012-03-13 17:47:21]

> We should check here that the script source is not changed after
BeforeCompile.

I would like to do this, but I did not find a reliable way of telling we are
processing BeforeCompile from within the native runtime.

[Søren Gjesse, 2012-03-14 09:49:26]

lgtm

Regarding only changing the script source in OnBeforeCompile you could add a
flag to the Script object and set that when leaving OnBeforeCompile.

[Yang, 2012-03-14 10:30:30]

On 2012/03/14 09:49:26, Søren Gjesse wrote:
> lgtm
> 
> Regarding only changing the script source in OnBeforeCompile you could add a
> flag to the Script object and set that when leaving OnBeforeCompile.

LGTM. I agree with Søren's suggestion to introduce a freeze flag that's set at
the end of OnBeforeCompile. Maybe it even makes sense to use BitField to merge
Type, CompilationType and this new freeze flag into one 32-bit int so that they
only occupy only one kPointerSize.

[pfeldman, 2012-03-14 14:06:04]

> Regarding only changing the script source in OnBeforeCompile you could add a
> flag to the Script object and set that when leaving OnBeforeCompile.

Done.

> Maybe it even makes sense to use BitField to merge
> Type, CompilationType and this new freeze flag into one 32-bit int so that
they
> only occupy only one kPointerSize.

I'd leave it to somebody more experienced in v8 if that is possible.

[Yang, 2012-03-14 14:14:20]

LGTM with one comment.

https://chromiumcodereview.appspot.com/9677043/diff/12001/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/9677043/diff/12001/src/runtime.cc#newc...
src/runtime.cc:12284: script->set_source(*source);
Not sure if silent failure is the best thing to do. Maybe return
isolate->ThrowIllegalOperation()?