content/common/socket_stream_messages.h - Issue 9677031: Bind RenderViewImpl routing_id to SocketStreamHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/socket_stream_messages.h

Issue 9677031: Bind RenderViewImpl routing_id to SocketStreamHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reflects review comments by tony and darin Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/socket_stream_messages.h

diff --git a/content/common/socket_stream_messages.h b/content/common/socket_stream_messages.h

index bb599c497313fdc4dd26e76f01a2069a2ff64d4f..f9cc64417a65a15c986d34e0ba548ebe66a98800 100644

--- a/content/common/socket_stream_messages.h

+++ b/content/common/socket_stream_messages.h

@@ -21,7 +21,10 @@

// The browser starts connecting asynchronously.

// Once Socket Stream connection is established, the browser will send

// SocketStreamMsg_Connected back.

-IPC_MESSAGE_CONTROL2(SocketStreamHostMsg_Connect,

+// |render_view_id| must be the routing id of RenderViewImpl to which the

+// WebSocket belongs.

wtc 2012/03/19 23:21:03 Nit: should "WebSocket" be changed "Socket Stream"

Takashi Toyoshima 2012/03/20 00:18:03 Thank you. It looks better. Done.

+IPC_MESSAGE_CONTROL3(SocketStreamHostMsg_Connect,

+ int /* render_view_id */,

GURL /* socket_url */,

int /* socket_id */)