Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Side by Side Diff: content/common/socket_stream_dispatcher.cc

Issue 9677031: Bind RenderViewImpl routing_id to SocketStreamHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: reflects review comments by tony and darin Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/socket_stream_dispatcher.h" 5 #include "content/common/socket_stream_dispatcher.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/id_map.h" 10 #include "base/id_map.h"
11 #include "base/lazy_instance.h" 11 #include "base/lazy_instance.h"
12 #include "base/memory/ref_counted.h" 12 #include "base/memory/ref_counted.h"
13 #include "base/message_loop.h" 13 #include "base/message_loop.h"
14 #include "content/common/child_thread.h" 14 #include "content/common/child_thread.h"
15 #include "content/common/socket_stream.h" 15 #include "content/common/socket_stream.h"
16 #include "content/common/socket_stream_handle_data.h"
16 #include "content/common/socket_stream_messages.h" 17 #include "content/common/socket_stream_messages.h"
17 #include "googleurl/src/gurl.h" 18 #include "googleurl/src/gurl.h"
18 #include "webkit/glue/websocketstreamhandle_bridge.h" 19 #include "webkit/glue/websocketstreamhandle_bridge.h"
19 #include "webkit/glue/websocketstreamhandle_delegate.h" 20 #include "webkit/glue/websocketstreamhandle_delegate.h"
21 #include "webkit/glue/websocketstreamhandle_impl.h"
darin (slow to review) 2012/03/20 06:46:59 still needed?
Takashi Toyoshima 2012/03/20 18:19:40 No. This inclusion was removed at Patch Set 8.
20 22
21 // IPCWebSocketStreamHandleBridge is owned by each SocketStreamHandle. 23 // IPCWebSocketStreamHandleBridge is owned by each SocketStreamHandle.
22 // It communicates with the main browser process via SocketStreamDispatcher. 24 // It communicates with the main browser process via SocketStreamDispatcher.
23 class IPCWebSocketStreamHandleBridge 25 class IPCWebSocketStreamHandleBridge
24 : public webkit_glue::WebSocketStreamHandleBridge { 26 : public webkit_glue::WebSocketStreamHandleBridge {
25 public: 27 public:
26 IPCWebSocketStreamHandleBridge( 28 IPCWebSocketStreamHandleBridge(
27 ChildThread* child_thread, 29 ChildThread* child_thread,
28 WebKit::WebSocketStreamHandle* handle, 30 WebKit::WebSocketStreamHandle* handle,
29 webkit_glue::WebSocketStreamHandleDelegate* delegate) 31 webkit_glue::WebSocketStreamHandleDelegate* delegate)
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 } 141 }
140 142
141 void IPCWebSocketStreamHandleBridge::DoConnect(const GURL& url) { 143 void IPCWebSocketStreamHandleBridge::DoConnect(const GURL& url) {
142 DCHECK(child_thread_); 144 DCHECK(child_thread_);
143 DCHECK_EQ(socket_id_, content::kNoSocketId); 145 DCHECK_EQ(socket_id_, content::kNoSocketId);
144 if (delegate_) 146 if (delegate_)
145 delegate_->WillOpenStream(handle_, url); 147 delegate_->WillOpenStream(handle_, url);
146 148
147 socket_id_ = all_bridges.Get().Add(this); 149 socket_id_ = all_bridges.Get().Add(this);
148 DCHECK_NE(socket_id_, content::kNoSocketId); 150 DCHECK_NE(socket_id_, content::kNoSocketId);
151 int render_view_id = MSG_ROUTING_NONE;
152 const SocketStreamHandleData* data =
153 SocketStreamHandleData::ForHandle(handle_);
154 if (data)
155 render_view_id = data->render_view_id();
149 AddRef(); // Released in OnClosed(). 156 AddRef(); // Released in OnClosed().
150 if (child_thread_->Send(new SocketStreamHostMsg_Connect(url, socket_id_))) { 157 if (child_thread_->Send(
158 new SocketStreamHostMsg_Connect(render_view_id, url, socket_id_))) {
151 DVLOG(1) << "Connect socket_id=" << socket_id_; 159 DVLOG(1) << "Connect socket_id=" << socket_id_;
152 // TODO(ukai): timeout to OnConnected. 160 // TODO(ukai): timeout to OnConnected.
153 } else { 161 } else {
154 DLOG(ERROR) << "IPC SocketStream_Connect failed."; 162 DLOG(ERROR) << "IPC SocketStream_Connect failed.";
155 OnClosed(); 163 OnClosed();
156 } 164 }
157 } 165 }
158 166
159 void IPCWebSocketStreamHandleBridge::DoClose() { 167 void IPCWebSocketStreamHandleBridge::DoClose() {
160 child_thread_->Send(new SocketStreamHostMsg_Close(socket_id_)); 168 child_thread_->Send(new SocketStreamHostMsg_Close(socket_id_));
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 } 225 }
218 226
219 void SocketStreamDispatcher::OnClosed(int socket_id) { 227 void SocketStreamDispatcher::OnClosed(int socket_id) {
220 IPCWebSocketStreamHandleBridge* bridge = 228 IPCWebSocketStreamHandleBridge* bridge =
221 IPCWebSocketStreamHandleBridge::FromSocketId(socket_id); 229 IPCWebSocketStreamHandleBridge::FromSocketId(socket_id);
222 if (bridge) 230 if (bridge)
223 bridge->OnClosed(); 231 bridge->OnClosed();
224 else 232 else
225 DLOG(ERROR) << "No SocketStreamHandleBridge for socket_id=" << socket_id; 233 DLOG(ERROR) << "No SocketStreamHandleBridge for socket_id=" << socket_id;
226 } 234 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698