content/common/socket_stream_handle_data.cc - Issue 9677031: Bind RenderViewImpl routing_id to SocketStreamHost

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/socket_stream_handle_data.cc

Issue 9677031: Bind RenderViewImpl routing_id to SocketStreamHost (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: reflects wtc's comments Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "content/common/socket_stream_handle_data.h"

	6

	7 #include "webkit/glue/websocketstreamhandle_impl.h"

	8

	9 using webkit_glue::WebSocketStreamHandleImpl;

	10 using WebKit::WebSocketStreamHandle;

	11

	12 // static

	13 const SocketStreamHandleData* SocketStreamHandleData::ForHandle(

	14 WebSocketStreamHandle* handle) {

	15 WebSocketStreamHandleImpl* impl =

	16 static_cast<WebSocketStreamHandleImpl*>(handle);

	17 if (!impl)
	darin (slow to review) 2012/03/20 06:46:59 nit: impl will only be null if handle was null. m nit: impl will only be null if handle was null. maybe it would be better to null-check handle first before doing anything else? Takashi Toyoshima 2012/03/20 18:19:40 Agreed. Fixed in the Patch Set 10. Agreed. Fixed in the Patch Set 10.
	18 return NULL;

	19 return static_cast<SocketStreamHandleData*>(impl->GetUserData(handle));

	20 }

OLD	NEW