Enable isolate tests with leg and legium.

lib/isolate/frog/isolateimpl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A native object that is shared across isolates. This object is visible to all
  * isolates running on the same worker (either UI or background web worker).
  *
  * This is code that is intended to 'escape' the isolate boundaries in order to
  * implement the semantics of isolates in JavaScript. Without this we would have
@@ skipping 179 matching lines @@
 
   /** Unregister a port on this isolate. */
   void unregister(int portId) {
     ports.remove(portId);
     if (ports.isEmpty()) {
       _globalState.isolates.remove(id); // indicate this isolate is not active
     }
   }
 }
 
+// We don't want to import the DOM library just because of window.setTimeout,
+// so we reconstruct the Window class here. The only conflict that could happen
+// with the other DOMWindow class would be because of subclasses.
+// Currently, none of the two Dart classes have subclasses.

[ngeoffray, 2012/03/12 23:18:36]

This is more of a cleanup than a hack IMO. Siggi, Eli let me know what you
think.

[Siggi Cherem (dart-lang), 2012/03/12 23:40:58]

looks good to me. I'm working on adding Timer to corelib, which is basically
based on this. Hopefully then we can hide this code behind the Timer interface. 

I don't plan to implement Timer outside the browser, so we will still need to
detect if it is available, for instance checking if new Timer(x, callback)
throws an exception.

[ngeoffray, 2012/03/13 12:51:37]

Sounds good.
I don't understand: if you're adding something to the corelib, it ought to be
available to both browser and standalone. Or are you saying that the actual
implementation of Timer in standalone will be implemented by someone else?

[Siggi Cherem (dart-lang), 2012/03/14 23:23:12]

It would be supported standalone in the VM, but not when compiling with frog to
run in d8. In nodejs we had setTimeout available, but I haven't found something
equivalent for d8. I was leaning to say that in such case Timer is not
available.

[ngeoffray, 2012/03/15 09:30:56]

Oh I see. So I guess you want to throw a runtime exception by doing something
like:

class Timer {
   Timer() {
      if (JS_CODE("typeof window == 'undefined')) {
        throw 'Timer not supported';
      }
      ....
   }
}

+typedef void _TimeoutHandler();
+class _Window native "@*DOMWindow" {
+  int setTimeout(_TimeoutHandler handler, int timeout) native;

[Siggi Cherem (dart-lang), 2012/03/12 23:40:58]

is this _TimeoutHandler needed, or can we simply do:
int setTimeout(void handler(), int timeout) native;
?

[ngeoffray, 2012/03/13 12:51:37]

Leg does not handle function type parameters very well right now. We're fixing
it.

[Siggi Cherem (dart-lang), 2012/03/14 23:23:12]

good to know. Thx.

+}
+_Window get _window() native
+    """return typeof window != 'undefined' ? window : (void 0);""";
 
 /** Represent the event loop on a javascript thread (DOM or worker). */
 class _EventLoop {
   Queue<_IsolateEvent> events;
 
   _EventLoop() : events = new Queue<_IsolateEvent>();
 
   void enqueue(isolate, fn, msg) {
     events.addLast(new _IsolateEvent(isolate, fn, msg));
   }
 
   _IsolateEvent dequeue() {
     if (events.isEmpty()) return null;
     return events.removeFirst();
   }
 
   /** Process a single event, if any. */
   bool runIteration() {
     final event = dequeue();
     if (event == null) {
       _globalState.closeWorker();
       return false;
     }
     event.process();
     return true;
   }
 
-  /** Function equivalent to [:window.setTimeout:] when available, or null. */
-  static Function _wrapSetTimeout() native """
-      return typeof window != 'undefined' ?
-          function(a, b) { window.setTimeout(a, b); } : undefined;
-  """;
-
   /**
    * Runs multiple iterations of the run-loop. If possible, each iteration is
    * run asynchronously.
    */
   void _runHelper() {
-    final setTimeout = _wrapSetTimeout();
-    if (setTimeout != null) {
+    if (_window != null) {
       // Run each iteration from the browser's top event loop.
       void next() {
         if (!runIteration()) return;
-        setTimeout(next, 0);
+        _window.setTimeout(next, 0);
       }
       next();
     } else {
       // Run synchronously until no more iterations are available.
       while (runIteration()) {}
     }
   }
 
   /**
    * Call [_runHelper] but ensure that worker exceptions are propragated. Note
@@ skipping 375 matching lines @@
       'command': 'start2',
       'id': workerId,
       // Note: we serialize replyPort twice because the child worker needs to
       // first deserialize the worker id, before it can correctly deserialize
       // the port (port deserialization is sensitive to what is the current
       // workerId).
       'replyTo': _serializeMessage(replyPort),
       'functionName': functionName }));
   }
 }