Chromium Code Reviews
Help | Chromium Project | Sign in
(258)

Issue 9677014: Add owners for src/google_update. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by Dirk Pranke
Modified:
3 years, 1 month ago
Reviewers:
robertshield, grt
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix ordering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A google_update/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Dirk Pranke
Hi all, I'm going through and making sure all of the directories immediately under src/ ...
3 years, 1 month ago (2012-03-12 21:28:11 UTC) #1
robertshield
lgtm https://chromiumcodereview.appspot.com/9677014/diff/1/google_update/OWNERS File google_update/OWNERS (right): https://chromiumcodereview.appspot.com/9677014/diff/1/google_update/OWNERS#newcode2 google_update/OWNERS:2: grt@chromium.org I can't think of anyone I would ...
3 years, 1 month ago (2012-03-12 23:39:14 UTC) #2
grt
3 years, 1 month ago (2012-03-13 00:52:55 UTC) #3
LGTM

On 2012/03/12 23:39:14, robertshield wrote:
> OCD nit: should probably be alphabetical so that grt@ guy is at the top.

I love you, man.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e0e3771