Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 96763002: Reupload CallIC changes. (Closed)

Created:
7 years ago by Toon Verwaest
Modified:
7 years ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Reupload CallIC changes. Relands https://codereview.chromium.org/91963003/ with fix for the invalid receiver patching in case of the global object / interceptor. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18161

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Mips #

Patch Set 4 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -492 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 3 chunks +15 lines, -2 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 2 3 16 chunks +40 lines, -115 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +13 lines, -6 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 3 15 chunks +41 lines, -121 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +15 lines, -2 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 2 3 16 chunks +40 lines, -116 lines 0 comments Download
M src/stub-cache.h View 3 chunks +15 lines, -1 line 0 comments Download
M src/stub-cache.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +17 lines, -8 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 3 15 chunks +40 lines, -121 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years ago (2013-11-29 12:17:38 UTC) #1
Igor Sheludko
Will lgtm after you fix notes )) https://codereview.chromium.org/96763002/diff/20001/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://codereview.chromium.org/96763002/diff/20001/src/arm/stub-cache-arm.cc#newcode2341 src/arm/stub-cache-arm.cc:2341: if (!object.is_null() ...
7 years ago (2013-11-29 12:39:42 UTC) #2
Toon Verwaest
7 years ago (2013-11-29 12:57:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r18161 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698