Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 967193002: Credential saving clank infobar for Smart Lock. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reusable_more_button
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index bc8c710db1f11c742537d876db1446e74199a28c..f9eed89f4c79ae9b96ecd3f4c9588bb1227d7745 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -189,8 +189,8 @@ bool ChromePasswordManagerClient::PromptUserToSavePassword(
password_manager::metrics_util::GroupIdToString(
password_manager::metrics_util::MonitoredDomainGroupId(
form_to_save->realm(), GetPrefs())));
- SavePasswordInfoBarDelegate::Create(
- web_contents(), form_to_save.Pass(), uma_histogram_suffix);
+ SavePasswordInfoBarDelegate::Create(web_contents(), form_to_save.Pass(),
gone 2015/03/02 17:39:38 nit: if the arguments don't fit, c++ style puts th
melandory 2015/03/03 11:55:46 I was also surprised when I saw how clang format f
Bernhard Bauer 2015/03/03 16:54:20 Yeah, the "either all arguments on one line, or ea
+ uma_histogram_suffix, type);
}
return true;
}

Powered by Google App Engine
This is Rietveld 408576698