Issue 9669028: ui/base: Move message_box_win.{h,cc} to ui/base/win.

Issue 9669028: ui/base: Move message_box_win.{h,cc} to ui/base/win. (Closed)

Created:
8 years, 9 months ago by tfarina

Modified:
8 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, tfarina, mihaip+watch_chromium.org, sadrul, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui/base: Move message_box_win.{h,cc} to ui/base/win. R=sky@chromium.org TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126144

Patch Set 2 : keep sorted #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -91 lines)			Patch
M	base/base_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	base/base_switches.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chrome_browser_main_win.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extensions_startup.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/importer_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/simple_message_box_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
D	ui/base/message_box_win.h	View		1 chunk	+0 lines, -27 lines	0 comments	Download
D	ui/base/message_box_win.cc	View		1 chunk	+0 lines, -41 lines	0 comments	Download
M	ui/base/ui_base_switches.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/ui_base_switches.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
A +	ui/base/win/message_box_win.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	ui/base/win/message_box_win.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	ui/ui.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/9669028/diff/1/ui/base/ui_base_switches.h File ui/base/ui_base_switches.h (right): http://codereview.chromium.org/9669028/diff/1/ui/base/ui_base_switches.h#newcode19 ui/base/ui_base_switches.h:19: UI_EXPORT extern const char kNoMessageBox[]; keep sorted.

8 years, 9 months ago (2012-03-11 22:07:55 UTC) #2

tfarina

8 years, 9 months ago (2012-03-11 22:32:23 UTC) #3

https://chromiumcodereview.appspot.com/9669028/diff/1/ui/base/ui_base_switches.h
File ui/base/ui_base_switches.h (right):

https://chromiumcodereview.appspot.com/9669028/diff/1/ui/base/ui_base_switche...
ui/base/ui_base_switches.h:19: UI_EXPORT extern const char kNoMessageBox[];
On 2012/03/11 22:07:56, sky wrote:
> keep sorted.

Done.

Expand Messages | Collapse Messages