Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 9669012: Remove the content dependency on allocator.gyp (Closed)

Created:
8 years, 9 months ago by Dirk Pranke
Modified:
8 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, akalin, willchan no longer on Chromium, jar (doing other things)
Visibility:
Public.

Description

Remove the content dependency on allocator.gyp I think I added this because webkit_glue had the dependency but wasn't declaring it, and this was before I fixed that (and before glue was a separate component). Having the dependency declared in both is not only wrong, but is causing heapchecker to fail on linux. R=jam@chromium.org BUG=112389 TEST=compile linux w/ component=shared_library and linux_use_heapchecker=1 and try to run unit_tests; it should actually run. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/content_renderer.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
8 years, 9 months ago (2012-03-09 22:14:03 UTC) #1
jam
8 years, 9 months ago (2012-03-09 23:29:26 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698