Issue 9668045: MIPS: Port Date-related changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9668045: MIPS: Port Date-related changes. (Closed)

Created:
8 years, 9 months ago by kalmard

Modified:
8 years, 9 months ago

Reviewers:
kisg, Paul Lind, ulan, danno, rossberg

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Port Date-related changes. Port r10981 (5ea074), r10982 (5f0d413) and r10983 (663a897d5). BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11003

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -2 lines)			Patch
M	src/mips/full-codegen-mips.cc	View	1 chunk	+46 lines, -0 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+40 lines, -0 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	2 chunks	+37 lines, -2 lines	1 comment	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

8 years, 9 months ago (2012-03-12 08:43:32 UTC) #3

LGTM. Thanks for the patch, I will land it for you.

http://codereview.chromium.org/9668045/diff/1/src/mips/lithium-mips.h
File src/mips/lithium-mips.h (right):

http://codereview.chromium.org/9668045/diff/1/src/mips/lithium-mips.h#newcode...
src/mips/lithium-mips.h:1008: class LSetDateField: public
LTemplateInstruction<1, 2, 1> {
I will remove this class since it is not used anymore.

Expand Messages | Collapse Messages