Issue 9668034: Fix issue 1950:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9668034: Fix issue 1950: (Closed)

Created:
8 years, 9 months ago by Ivan Posva

Modified:
8 years, 9 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Fix issue 1950: - enable-checked-mode forces --enable_type_checks and --enable_asserts. Committed: https://code.google.com/p/dart/source/detail?r=5269

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -0 lines)			Patch
M	vm/flags.h	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	vm/flags.cc	View	5 chunks	+30 lines, -0 lines	2 comments	Download
M	vm/parser.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/9668034/diff/1/vm/flags.cc File vm/flags.cc (right): https://chromiumcodereview.appspot.com/9668034/diff/1/vm/flags.cc#newcode62 vm/flags.cc:62: // No value to print here. You could ...

8 years, 9 months ago (2012-03-09 23:16:03 UTC) #2

Ivan Posva

8 years, 9 months ago (2012-03-09 23:20:37 UTC) #3

https://chromiumcodereview.appspot.com/9668034/diff/1/vm/flags.cc
File vm/flags.cc (right):

https://chromiumcodereview.appspot.com/9668034/diff/1/vm/flags.cc#newcode62
vm/flags.cc:62: // No value to print here.
On 2012/03/09 23:16:03, regis wrote:
> You could maybe print the name of the flag.

Done.

Expand Messages | Collapse Messages