Implement BrowserPluginPlaceholder.

content/renderer/plugins/browser_plugin_placeholder.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[jam, 2012/03/12 16:30:09]

content/renderer/plugins is a bit misleading, since there's a bunch of generic
plugins code already in content/renderer. this stuff is also more
"browser_plugin" or "browser_tag" than just "plugins".

do you see a lot of files added for this feature to justify its own
subdirectory?

[Fady Samuel, 2012/03/12 22:11:44]

Currently there are about a half dozen new files. However, once the browser
plugin has an API, I'm sure that will blow up to many more. I believe the
current thought is the browser tag is a shadow DOM facade on top of the browser
plugin so it seems to make sense to me to name it based on what it is, rather
than how it appears. Moving it to a browser_plugin directory.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_RENDERER_PLUGINS_BROWSER_PLUGIN_PLACEHOLDER_H_
+#define CONTENT_RENDERER_PLUGINS_BROWSER_PLUGIN_PLACEHOLDER_H_
+#pragma once
+
+#include "base/process.h"
+#include "content/public/renderer/render_process_observer.h"

[jam, 2012/03/12 16:30:09]

why?

[Fady Samuel, 2012/03/12 22:11:44]

Doesn't look like they are necessary. Probably a remnant of an earlier version
of this file. Thanks for catching that.

+#include "content/public/renderer/render_view_observer.h"

[jam, 2012/03/12 16:30:09]

ditto

[Fady Samuel, 2012/03/12 22:11:44]

Done.

+#include "ipc/ipc_channel_handle.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebString.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebPluginParams.h"
+#include "webkit/plugins/webview_plugin.h"
+
+namespace content {
+class RenderThread;

[jam, 2012/03/12 16:30:09]

why?

[Fady Samuel, 2012/03/12 22:11:44]

Done.

+class RenderView;
+}
+
+namespace WebKit {
+class WebFrame;

[jam, 2012/03/12 16:30:09]

nit: not needed since thi sis in webview_plugin.h

[Fady Samuel, 2012/03/12 22:11:44]

Done.

+class WebPlugin;
+}
+
+class BrowserPluginPlaceholder: public webkit::WebViewPlugin::Delegate {

[jam, 2012/03/12 16:30:09]

there should be a comment on this class saying what it's used for

[Fady Samuel, 2012/03/12 22:11:44]

Done.

+ public:
+  // Creates a new WebViewPlugin with a BrowserPluginPlaceholder as a delegate.
+  static webkit::WebViewPlugin* Create(
+      content::RenderView* render_view,
+      WebKit::WebFrame* frame,
+      const WebKit::WebPluginParams& params);
+
+  static BrowserPluginPlaceholder* FromID(int id);

[jam, 2012/03/12 16:30:09]

it's hard to see if this method is needed or not, or if there's an alternative
to avoiding the static map, since the code that uses this isn't sent for review
yet. why is this needed?

[Fady Samuel, 2012/03/12 22:11:44]

One RenderView can have multiple browser plugins within it. I needed a way to
grab the right one and talk to it. I solved this problem by giving each
BrowserPluginPlaceholder a unique ID before requesting the creation of a new
guest RenderView from the browser process. That id is passed to the browser
process. Once the new RenderView is up and running, it sends an IPC to the host
RenderView back with the ID of the BrowserPluginPlaceholder. Now it knows which
placeholder to swap out with a guest.

+
+  void RegisterPlaceholder(int id, BrowserPluginPlaceholder* placeholder);
+  void UnregisterPlaceholder(int id);

[jam, 2012/03/12 16:30:09]

ditto

[Fady Samuel, 2012/03/12 22:11:44]

Please see above.

+
+  int GetID() { return id_; }
+
+  webkit::WebViewPlugin* plugin() { return plugin_; }
+
+  const WebKit::WebPluginParams& plugin_params() const;
+
+  void GuestReady(base::ProcessHandle process_handle,
+                  const IPC::ChannelHandle& channel_handle);
+
+  content::RenderView* render_view() { return render_view_; }
+
+ private:
+  BrowserPluginPlaceholder(content::RenderView* render_view,
+                           WebKit::WebFrame* frame,
+                           const WebKit::WebPluginParams& params,
+                           const std::string& html_data);
+  virtual ~BrowserPluginPlaceholder();
+
+  // Grabs the width, height, and source URL of the browser plugin
+  // from the element's attributes. If not found, it uses the defaults
+  // specified here as parameters.
+  void GetPluginParameters(int default_width, int default_height,
+                           const std::string& default_src);
+  // Replace this placeholder with the real browser plugin.
+  void LoadGuest(WebKit::WebPlugin* new_plugin);
+
+  virtual void BindWebFrame(WebKit::WebFrame* frame) OVERRIDE { }
+  virtual void WillDestroyPlugin() OVERRIDE;
+  virtual void ShowContextMenu(const WebKit::WebMouseEvent&) OVERRIDE { }
+
+  content::RenderView* render_view_;
+  WebKit::WebPluginParams plugin_params_;
+  webkit::WebViewPlugin* plugin_;
+  int id_;
+  int width_;
+  int height_;

[jam, 2012/03/12 16:30:09]

nit: instead of width_ and height_, use gfx::Size

[Fady Samuel, 2012/03/12 22:11:44]

Done.

+  std::string src_;
+
+  DISALLOW_COPY_AND_ASSIGN(BrowserPluginPlaceholder);
+};
+
+#endif  // CONTNET_RENDERER_PLUGINS_BROWSER_PLUGIN_PLACEHOLDER_H_