Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 9668028: [Sync] Create new top-level sync/ directory (Closed)

Created:
8 years, 9 months ago by akalin
Modified:
8 years, 9 months ago
CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, mihaip+watch_chromium.org, cbentzel+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, dhollowa+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

[Sync] Create new top-level sync/ directory Move sync .proto files to sync/protocol. Update all references. This begins the Great Sync Migration. BUG=117585, 43624 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125967

Patch Set 1 #

Patch Set 2 : Fix checkdeps #

Patch Set 3 : sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -1873 lines) Patch
M chrome/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/app_notification_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/app_notification_manager_sync_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_sync_data_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/settings/setting_sync_data.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/settings/settings_sync_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/settings/syncable_settings_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_model_associator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/abstract_profile_sync_service_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/api/sync_change_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/api/sync_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/backend_migrator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/backend_migrator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/apply_updates_command_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/build_commit_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/clear_data_command_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/conflict_resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/download_updates_command.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/download_updates_command_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/net/server_connection_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/nigori_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/nigori_util_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/process_commit_response_command_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/syncapi_internal.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncer_proto_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncer_proto_util_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sync/engine/syncer_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/syncproto.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/verify_updates_command.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/verify_updates_command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/password_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_associator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_change_processor.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/theme_change_processor.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/internal_api/base_node.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/internal_api/base_node.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/sync/internal_api/change_record.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/internal_api/change_record_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/internal_api/change_reorder_buffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/internal_api/debug_info_event_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/internal_api/read_node_mock.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/internal_api/syncapi_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/internal_api/write_node.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/sync/protocol/app_notification_specifics.proto View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/sync/protocol/app_setting_specifics.proto View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/sync/protocol/app_specifics.proto View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/sync/protocol/autofill_specifics.proto View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/sync/protocol/bookmark_specifics.proto View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/sync/protocol/client_commands.proto View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/sync/protocol/client_debug_info.proto View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/sync/protocol/encryption.proto View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/sync/protocol/extension_setting_specifics.proto View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/sync/protocol/extension_specifics.proto View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/sync/protocol/nigori_specifics.proto View 1 chunk +0 lines, -94 lines 0 comments Download
D chrome/browser/sync/protocol/password_specifics.proto View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/sync/protocol/preference_specifics.proto View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/sync/protocol/proto_enum_conversions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/protocol/proto_value_conversions.cc View 1 chunk +16 lines, -16 lines 0 comments Download
M chrome/browser/sync/protocol/proto_value_conversions_unittest.cc View 1 chunk +16 lines, -16 lines 0 comments Download
D chrome/browser/sync/protocol/search_engine_specifics.proto View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/sync/protocol/session_specifics.proto View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/sync/protocol/sync.proto View 1 chunk +0 lines, -682 lines 0 comments Download
D chrome/browser/sync/protocol/sync_enums.proto View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/browser/sync/protocol/sync_proto.gyp View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/sync/protocol/test.proto View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/sync/protocol/theme_specifics.proto View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/sync/protocol/typed_url_specifics.proto View 1 chunk +0 lines, -41 lines 0 comments Download
M chrome/browser/sync/sessions/debug_info_getter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/directory_backing_store.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/directory_backing_store_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 1 chunk +15 lines, -15 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/syncable_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/engine/mock_connection_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/engine/mock_connection_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/util/cryptographer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/util/cryptographer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/util/protobuf_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/webdata/autocomplete_syncable_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M net/net.gyp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/test/test_server.cc View 1 chunk +1 line, -4 lines 0 comments Download
A sync/OWNERS View 1 chunk +9 lines, -0 lines 0 comments Download
A + sync/protocol/app_notification_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/app_setting_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/app_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/autofill_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/bookmark_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/client_commands.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/client_debug_info.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/encryption.proto View 1 chunk +1 line, -1 line 0 comments Download
A + sync/protocol/extension_setting_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/extension_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/nigori_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/password_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/preference_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/search_engine_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/session_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/sync.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/sync_enums.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/sync_proto.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
A + sync/protocol/test.proto View 1 chunk +1 line, -1 line 0 comments Download
A + sync/protocol/theme_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sync/protocol/typed_url_specifics.proto View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
akalin
+sky for search engines +mmenke for net +darin for top-level directory +tim for everything
8 years, 9 months ago (2012-03-09 22:06:19 UTC) #1
mmenke
net changes LGTM.
8 years, 9 months ago (2012-03-09 22:10:40 UTC) #2
darin (slow to review)
LGTM for src/sync/ creation.
8 years, 9 months ago (2012-03-09 22:32:29 UTC) #3
sky
LGTM in the future feel free to TBR these sort of things.
8 years, 9 months ago (2012-03-09 23:36:49 UTC) #4
tim (not reviewing)
LGTM!
8 years, 9 months ago (2012-03-10 00:06:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/9668028/10002
8 years, 9 months ago (2012-03-10 00:19:13 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-10 00:19:49 UTC) #7
Can't apply patch for file chrome/chrome_browser_extensions.gypi.
While running patch -p1 --forward --force;
patching file chrome/chrome_browser_extensions.gypi
Hunk #1 FAILED at 11.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/chrome_browser_extensions.gypi.rej

Powered by Google App Engine
This is Rietveld 408576698