Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 9668013: Add explicit dependency on v8_base (Closed)

Created:
8 years, 9 months ago by Yaron
Modified:
8 years, 9 months ago
CC:
v8-dev, John Grabowski, Satish, Jesse Greenwald, Ted C
Visibility:
Public.

Description

Add explicit dependency on v8_base This is necessary in order to link v8_shell (for host) with the Android toolchain. Without it, the line in the makefile is: $(builddir)/v8_shell: LD_INPUTS := $(OBJS) $(obj).host/v8/tools/gyp/libv8_snapshot.a $(obj).host/v8/tools/gyp/libv8_base.a Now it appears as: $(builddir)/v8_shell: LD_INPUTS := $(OBJS) $(obj).host/v8/tools/gyp/libv8_base.a $(obj).host/v8/tools/gyp/libv8_snapshot.a and it successfully links. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=11005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M tools/gyp/v8.gyp View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yaron
We're currently trying to get chromium's unit_tests target to build for the Android configuration. However, ...
8 years, 9 months ago (2012-03-09 18:06:33 UTC) #1
Jakob Kummerow
8 years, 9 months ago (2012-03-12 10:24:00 UTC) #2
It's sad that this hack is necessary, but since you've added an explaining
comment, LGTM.

I'll land it for you.

Powered by Google App Engine
This is Rietveld 408576698