Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: chrome/browser/resources/options2/chromeos/internet_detail.html

Issue 9668010: Move proxy handling into network details. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address reviewer feedback. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <div id="detailsInternetPage" class="page" hidden> 1 <div id="detailsInternetPage" class="page" hidden>
2 <div id="internet-details-content-area" class="content-area"> 2 <div id="internet-details-content-area" class="content-area">
3 <!-- Network header --> 3 <!-- Network header -->
4 <div> 4 <div>
5 <div id="network-details-header"> 5 <div id="network-details-header">
6 <div id="network-details-title"></div> 6 <div id="network-details-title"></div>
7 <div id="network-details-subtitle"> 7 <div id="network-details-subtitle">
8 <span id="network-details-subtitle-status"></span> 8 <span id="network-details-subtitle-status"></span>
9 <span id="network-details-subtitle-separator"> - </span> 9 <span id="network-details-subtitle-separator"> - </span>
10 <span id="network-details-subtitle-type"></span> 10 <span id="network-details-subtitle-type"></span>
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 </span> 49 </span>
50 <span id="internetNavTab" class="tab" tab-contents="internetTab"> 50 <span id="internetNavTab" class="tab" tab-contents="internetTab">
51 <span class="tab-label" i18n-content="networkTabLabel"></span> 51 <span class="tab-label" i18n-content="networkTabLabel"></span>
52 <span class="active-tab-label" i18n-content="networkTabLabel"></span> 52 <span class="active-tab-label" i18n-content="networkTabLabel"></span>
53 </span> 53 </span>
54 <span id="security-nav-tab" class="tab cellular-details gsm-only" 54 <span id="security-nav-tab" class="tab cellular-details gsm-only"
55 tab-contents="security-tab"> 55 tab-contents="security-tab">
56 <span class="tab-label" i18n-content="securityTabLabel"></span> 56 <span class="tab-label" i18n-content="securityTabLabel"></span>
57 <span class="active-tab-label" i18n-content="securityTabLabel"></span> 57 <span class="active-tab-label" i18n-content="securityTabLabel"></span>
58 </span> 58 </span>
59 <span id="internet-proxy-nav-tab" class="tab proxy-details"
60 tab-contents="network-proxy-tab">
61 <span class="tab-label" i18n-content="proxyTabLabel"></span>
62 <span class="active-tab-label" i18n-content="proxyTabLabel"></span>
63 </span>
59 </div> 64 </div>
60 <div id="wifiNetworkTab" class="subpages-tab-contents wifi-details"> 65 <div id="wifiNetworkTab" class="subpages-tab-contents wifi-details">
61 <section> 66 <section>
62 <table class="ssid-table"> 67 <table class="ssid-table">
63 <tr> 68 <tr>
64 <td class="option-name" i18n-content="inetSsid"></td> 69 <td class="option-name" i18n-content="inetSsid"></td>
65 <td id="inetSsid" class="option-value"></td> 70 <td id="inetSsid" class="option-value"></td>
66 </tr> 71 </tr>
67 </table> 72 </table>
68 </section> 73 </section>
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
337 <span i18n-content="useStaticIP"></span> 342 <span i18n-content="useStaticIP"></span>
338 </label> 343 </label>
339 <span class="controlled-setting-indicator" data="ipconfigStatic" 344 <span class="controlled-setting-indicator" data="ipconfigStatic"
340 for="ipTypeStatic"></span> 345 for="ipTypeStatic"></span>
341 </div> 346 </div>
342 <div id="ipConfigManagement" class="settings-list"> 347 <div id="ipConfigManagement" class="settings-list">
343 <list id="ipConfigList"></list> 348 <list id="ipConfigList"></list>
344 </div> 349 </div>
345 </div> 350 </div>
346 </section> 351 </section>
347 <section id="change-proxy-section">
348 <div>
349 <button id="change-proxy-button" i18n-content="changeProxyButton">
350 </button>
351 </div>
352 </section>
353 </div> 352 </div>
354 <div id="security-tab" 353 <div id="security-tab"
355 class="subpages-tab-contents cellular-details gsm-only"> 354 class="subpages-tab-contents cellular-details gsm-only">
356 <div id="cellular-security-options"> 355 <div id="cellular-security-options">
357 <section> 356 <section>
358 <div id="sim-pin-lock" class="checkbox"> 357 <div id="sim-pin-lock" class="checkbox">
359 <label> 358 <label>
360 <input id="sim-card-lock-enabled" type="checkbox"> 359 <input id="sim-card-lock-enabled" type="checkbox">
361 <span i18n-content="lockSimCard"></span> 360 <span i18n-content="lockSimCard"></span>
362 </label> 361 </label>
363 <span class="controlled-setting-indicator" data="simCardLockEnabled" 362 <span class="controlled-setting-indicator" data="simCardLockEnabled"
364 for="sim-card-lock-enabled"></span> 363 for="sim-card-lock-enabled"></span>
365 </div> 364 </div>
366 </section> 365 </section>
367 <section> 366 <section>
368 <div id="change-pin-area"> 367 <div id="change-pin-area">
369 <button id="change-pin" i18n-content="changePinButton"></button> 368 <button id="change-pin" i18n-content="changePinButton"></button>
370 <span class="controlled-setting-indicator" data="simCardLockEnabled" 369 <span class="controlled-setting-indicator" data="simCardLockEnabled"
371 for="change-pin"></span> 370 for="change-pin"></span>
372 </div> 371 </div>
373 </section> 372 </section>
374 </div> 373 </div>
375 </div> 374 </div>
375 <div id="network-proxy-tab" class="subpages-tab-contents">
376 <section>
377 <div id="info-banner" hidden>
378 <span id="banner-icon" class="managed-prefs-icon"></span>
379 <span id="banner-text" class="managed-prefs-text"></span>
380 </div>
381 <div class="radio">
382 <label>
383 <input id="directProxy" type="radio" name="proxytype" value="1"
384 pref="cros.session.proxy.type">
385 <span i18n-content="proxyDirectInternetConnection"></span>
386 </label>
387 </div>
388 <div class="radio">
389 <label>
390 <input id="manualProxy" type="radio" name="proxytype" value="2"
391 pref="cros.session.proxy.type">
392 <span i18n-content="proxyManual"></span>
393 </label>
394 </div>
395 <div class="checkbox">
396 <label>
397 <input id="proxyAllProtocols" type="checkbox"
398 pref="cros.session.proxy.single">
399 <span i18n-content="sameProxyProtocols"></span>
400 </label>
401 </div>
402 <div id="singleProxy">
403 <table>
404 <tr>
405 <td>
406 <span i18n-content="httpProxy"></span>
407 <input id="proxyHostSingleName" type="text" size="25"
408 pref="cros.session.proxy.singlehttp" disabled>
409 </td>
410 <td>
411 <span i18n-content="proxyPort"></span>
412 <input id="proxyHostSinglePort" type="text" data-type="number"
413 size="4" pref="cros.session.proxy.singlehttpport" disabled>
414 </td>
415 </tr>
416 </table>
417 </div>
418 <div id="multiProxy">
419 <table>
420 <tr>
421 <td>
422 <span i18n-content="httpProxy"></span>
423 </td>
424 <td>
425 <input id="proxyHostName" type="text" size="25"
426 pref="cros.session.proxy.httpurl" disabled>
427 </td>
428 <td>
429 <span i18n-content="proxyPort"></span>
430 </td>
431 <td>
432 <input id="proxyHostPort" type="text" data-type="number"
433 size="4" pref="cros.session.proxy.httpport" disabled>
434 </td>
435 </tr>
436 <tr>
437 <td>
438 <span i18n-content="secureHttpProxy"></span>
439 </td>
440 <td>
441 <input id="secureProxyHostName" type="text" size="25"
442 pref="cros.session.proxy.httpsurl" disabled>
443 </td>
444 <td>
445 <span i18n-content="proxyPort"></span>
446 </td>
447 <td>
448 <input id="secureProxyPort" type="text" data-type="number" size= "4"
csilv 2012/03/12 18:44:35 nit: wrap to 80 cols
kevers 2012/03/12 19:55:10 Done.
449 pref="cros.session.proxy.httpsport" disabled>
450 </td>
451 </tr>
452 <tr>
453 <td>
454 <span i18n-content="ftpProxy"></span>
455 </td>
456 <td>
457 <input id="ftpProxy" type="text" size="25"
458 pref="cros.session.proxy.ftpurl" disabled>
459 </td>
460 <td>
461 <span i18n-content="proxyPort"></span>
462 </td>
463 <td>
464 <input id="ftpProxyPort" type="text" data-type="number" size="4"
465 pref="cros.session.proxy.ftpport" disabled>
466 </td>
467 </tr>
468 <tr>
469 <td>
470 <span i18n-content="socksHost"></span>
471 </td>
472 <td>
473 <input id="socksHost" type="text" size="25"
474 pref="cros.session.proxy.socks" disabled>
475 </td>
476 <td>
477 <span i18n-content="proxyPort"></span>
478 </td>
479 <td>
480 <input id="socksPort" type="text" data-type="number" size="4"
481 pref="cros.session.proxy.socksport" disabled>
482 </td>
483 </tr>
484 </table>
485 </div>
486 <div class="radio">
487 <label>
488 <input id="autoProxy" type="radio" name="proxytype" value="3"
489 pref="cros.session.proxy.type">
490 <span i18n-content="proxyAutomatic"></span>
491 </label>
492 </div>
493 <div>
494 <label>
495 <div i18n-content="proxyConfigUrl"></div>
496 <input id="proxyConfig" type="url" size="50"
497 pref="cros.session.proxy.pacurl">
498 </label>
499 </div>
500 <div id="advancedConfig">
501 <h3 i18n-content="advanced_proxy_config"></h3>
502 <div class="option vbox flex">
503 <div i18n-content="proxyBypass"></div>
504 <list id="ignoredHostList"></list>
505 <input id="newHost" type="url" size="30">
506 <button id="addHost" i18n-content="addHost"></button>
507 <button id="removeHost" i18n-content="removeHost"></button>
508 </div>
509 </div>
510 </section>
511 </div>
376 </div> 512 </div>
377 <div class="action-area"> 513 <div class="action-area">
378 <div class="button-strip"> 514 <div class="button-strip">
379 <!-- TODO(dbeam): Clarify style guide regarding tag wrap. --> 515 <!-- TODO(dbeam): Clarify style guide regarding tag wrap. -->
516 <!-- TODO(kevers): Style cleanup. IDs should be hyphen-delimited
517 lowercase. -->
380 <button id="detailsInternetDismiss" i18n-content="detailsInternetDismiss"> 518 <button id="detailsInternetDismiss" i18n-content="detailsInternetDismiss">
381 </button> 519 </button>
382 <button id="detailsInternetLogin" i18n-content="connect_button"></button> 520 <button id="detailsInternetLogin" i18n-content="connect_button"></button>
383 <button id="detailsInternetDisconnect" i18n-content="disconnect_button"> 521 <button id="detailsInternetDisconnect" i18n-content="disconnect_button">
384 </button> 522 </button>
385 <button id="activateDetails" i18n-content="activate_button"></button> 523 <button id="activateDetails" i18n-content="activate_button"></button>
386 <button id="buyplanDetails" i18n-content="buyplan_button"></button> 524 <button id="buyplanDetails" i18n-content="buyplan_button"></button>
387 <button id="viewAccountDetails" i18n-content="view_account_button"> 525 <button id="viewAccountDetails" i18n-content="view_account_button">
388 </button> 526 </button>
389 </div> 527 </div>
390 </div> 528 </div>
391 </div> 529 </div>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698