Add a new policy to allow for release channel delegation.

Add a new policy to allow for release channel delegation.

BUG=chromium-os:26312
TEST=Enroll. Set the policy in CPanel to delegated and verify it is editable.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126659

[pastarmovj, 2012-03-09 14:48:39]

@Joao: Please review the CL in general.

@James: Please review the webui parts. 

Please note I changed the code in the SetReleaseChannel function because it was
trying to set a non-existing local pref which led to crash on CrOS. The release
channel is a device policy and must be set through the CrosSettings interface
not through the pref system.

@Bin: Are you ok with putting this new policy in the ReleaseChannelProto
protobuf?

[Joao da Silva, 2012-03-09 15:15:55]

lgtm with nits

http://codereview.chromium.org/9668001/diff/1/chrome/browser/chromeos/device_...
File chrome/browser/chromeos/device_settings_provider.cc (right):

http://codereview.chromium.org/9668001/diff/1/chrome/browser/chromeos/device_...
chrome/browser/chromeos/device_settings_provider.cc:502:
policy.release_channel().release_channel_delegated());
Nit: indent these 2 lines

http://codereview.chromium.org/9668001/diff/1/chrome/browser/policy/proto/chr...
File chrome/browser/policy/proto/chrome_device_policy.proto (right):

http://codereview.chromium.org/9668001/diff/1/chrome/browser/policy/proto/chr...
chrome/browser/policy/proto/chrome_device_policy.proto:81: // If
|user_delegated| is set to true, the user can select the channel.
Nit: newline before the comment

http://codereview.chromium.org/9668001/diff/1/chrome/browser/ui/webui/help/he...
File chrome/browser/ui/webui/help/help_handler.cc (right):

http://codereview.chromium.org/9668001/diff/1/chrome/browser/ui/webui/help/he...
chrome/browser/ui/webui/help/help_handler.cc:232: // For local owner set the
field in the policy blob too.
Please drop a comment explaining why IsCurrentUserOwner() called again here, as
discussed offline.

[James Hawkins, 2012-03-09 19:29:12]

lgtm

[pastarmovj, 2012-03-12 13:06:53]

Thanks for reviewing this CL, guys!

@Joao: Can you please look at the small addition in device_policy_cache.cc -
adding the new policy to about:policy.

http://codereview.chromium.org/9668001/diff/1/chrome/browser/chromeos/device_...
File chrome/browser/chromeos/device_settings_provider.cc (right):

http://codereview.chromium.org/9668001/diff/1/chrome/browser/chromeos/device_...
chrome/browser/chromeos/device_settings_provider.cc:502:
policy.release_channel().release_channel_delegated());
On 2012/03/09 15:15:55, Joao da Silva wrote:
> Nit: indent these 2 lines

I don't think those have to be indented. Also from consistency point of view,
this is how the other such lines look like and those even went through the
readability review I had on this file. ;)

http://codereview.chromium.org/9668001/diff/1/chrome/browser/policy/proto/chr...
File chrome/browser/policy/proto/chrome_device_policy.proto (right):

http://codereview.chromium.org/9668001/diff/1/chrome/browser/policy/proto/chr...
chrome/browser/policy/proto/chrome_device_policy.proto:81: // If
|user_delegated| is set to true, the user can select the channel.
On 2012/03/09 15:15:55, Joao da Silva wrote:
> Nit: newline before the comment

Done.

http://codereview.chromium.org/9668001/diff/1/chrome/browser/ui/webui/help/he...
File chrome/browser/ui/webui/help/help_handler.cc (right):

http://codereview.chromium.org/9668001/diff/1/chrome/browser/ui/webui/help/he...
chrome/browser/ui/webui/help/help_handler.cc:232: // For local owner set the
field in the policy blob too.
On 2012/03/09 15:15:55, Joao da Silva wrote:
> Please drop a comment explaining why IsCurrentUserOwner() called again here,
as
> discussed offline.

Done.

[Joao da Silva, 2012-03-12 15:12:01]

http://codereview.chromium.org/9668001/diff/6001/chrome/browser/policy/device...
File chrome/browser/policy/device_policy_cache.cc (right):

http://codereview.chromium.org/9668001/diff/6001/chrome/browser/policy/device...
chrome/browser/policy/device_policy_cache.cc:422:
policies->Set(key::kDeviceMetricsReportingEnabled,
Wrong key.

[James Hawkins, 2012-03-12 18:08:19]

SLGTM

[pastarmovj, 2012-03-13 15:03:29]

@Joao: Fixed the wrong key, sorry for forgetting that in the first place. Are
you still LGTM?

@James: Nothing changed in the files you own so this should be a nop for you. :)

http://codereview.chromium.org/9668001/diff/6001/chrome/browser/policy/device...
File chrome/browser/policy/device_policy_cache.cc (right):

http://codereview.chromium.org/9668001/diff/6001/chrome/browser/policy/device...
chrome/browser/policy/device_policy_cache.cc:422:
policies->Set(key::kDeviceMetricsReportingEnabled,
On 2012/03/12 15:12:01, Joao da Silva wrote:
> Wrong key.

Done.

[Joao da Silva, 2012-03-13 16:48:16]

lgtm

[James Hawkins, 2012-03-13 17:32:33]

SLGTM