Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 9668001: Add a new policy to allow for release channel delegation. (Closed)

Created:
8 years, 9 months ago by pastarmovj
Modified:
8 years, 9 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add a new policy to allow for release channel delegation. BUG=chromium-os:26312 TEST=Enroll. Set the policy in CPanel to delegated and verify it is editable. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126659

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments and added the policy to the about:policy. #

Total comments: 2

Patch Set 3 : Addressed comments. #

Patch Set 4 : ToT rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -54 lines) Patch
M chrome/app/policy/policy_templates.json View 1 2 3 3 chunks +41 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/cros_settings_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros_settings_names.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/device_settings_provider.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/policy/device_policy_cache.cc View 1 2 3 1 chunk +21 lines, -12 lines 0 comments Download
M chrome/browser/policy/proto/chrome_device_policy.proto View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 1 2 3 3 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/about_page_handler.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/test/functional/policy_test_cases.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pastarmovj
@Joao: Please review the CL in general. @James: Please review the webui parts. Please note ...
8 years, 9 months ago (2012-03-09 14:48:39 UTC) #1
Joao da Silva
lgtm with nits http://codereview.chromium.org/9668001/diff/1/chrome/browser/chromeos/device_settings_provider.cc File chrome/browser/chromeos/device_settings_provider.cc (right): http://codereview.chromium.org/9668001/diff/1/chrome/browser/chromeos/device_settings_provider.cc#newcode502 chrome/browser/chromeos/device_settings_provider.cc:502: policy.release_channel().release_channel_delegated()); Nit: indent these 2 lines ...
8 years, 9 months ago (2012-03-09 15:15:55 UTC) #2
James Hawkins
lgtm
8 years, 9 months ago (2012-03-09 19:29:12 UTC) #3
pastarmovj
Thanks for reviewing this CL, guys! @Joao: Can you please look at the small addition ...
8 years, 9 months ago (2012-03-12 13:06:53 UTC) #4
Joao da Silva
http://codereview.chromium.org/9668001/diff/6001/chrome/browser/policy/device_policy_cache.cc File chrome/browser/policy/device_policy_cache.cc (right): http://codereview.chromium.org/9668001/diff/6001/chrome/browser/policy/device_policy_cache.cc#newcode422 chrome/browser/policy/device_policy_cache.cc:422: policies->Set(key::kDeviceMetricsReportingEnabled, Wrong key.
8 years, 9 months ago (2012-03-12 15:12:01 UTC) #5
James Hawkins
SLGTM
8 years, 9 months ago (2012-03-12 18:08:19 UTC) #6
pastarmovj
@Joao: Fixed the wrong key, sorry for forgetting that in the first place. Are you ...
8 years, 9 months ago (2012-03-13 15:03:29 UTC) #7
Joao da Silva
lgtm
8 years, 9 months ago (2012-03-13 16:48:16 UTC) #8
James Hawkins
8 years, 9 months ago (2012-03-13 17:32:33 UTC) #9
SLGTM

Powered by Google App Engine
This is Rietveld 408576698