Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 9667038: Merge 108780 - [v8] when a named item on document goes out of scope, actually remove it (Closed)

Created:
8 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Merge 108780 - [v8] when a named item on document goes out of scope, actually remove it https://bugs.webkit.org/show_bug.cgi?id=79409 Reviewed by Adam Barth. Source/WebCore: The original change already included the code, but it led to some problems, so it was reverted in http://trac.webkit.org/changeset/63845. However, not removing the items leaks a considerable amount of memory, so I'm adding the code back. The bug that led to the revert was that the accessor was removed unconditionally. I'm now only removing it, when the last item with that name is removed. Test: fast/dom/HTMLDocument/named-item.html * bindings/v8/V8DOMWindowShell.cpp: (WebCore::V8DOMWindowShell::namedItemRemoved): LayoutTests: * fast/dom/HTMLDocument/named-item-expected.txt: Added. * fast/dom/HTMLDocument/named-item.html: Added. TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=110400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, --2 lines) Patch
A + LayoutTests/fast/dom/HTMLDocument/named-item.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/dom/HTMLDocument/named-item-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/bindings/v8/V8DOMWindowShell.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
8 years, 9 months ago (2012-03-11 22:06:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698