Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: frog/leg/ssa/codegen.dart

Issue 9667027: Collect is checks to only emit the ones that are needed. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/leg/ssa/codegen.dart
===================================================================
--- frog/leg/ssa/codegen.dart (revision 5280)
+++ frog/leg/ssa/codegen.dart (working copy)
@@ -944,6 +944,7 @@
void visitIs(HIs node) {
Element element = node.typeExpression;
+ compiler.registerIsCheck(element);
LibraryElement coreLibrary = compiler.coreLibrary;
ClassElement objectClass = coreLibrary.find(const SourceString('Object'));
HInstruction input = node.expression;
@@ -1004,6 +1005,7 @@
// First check if the object is not a Dart object. If the
// object is a Dart object, we know the property check was
// sufficient.
+ compiler.registerIsCheck(objectClass);
buffer.add('!');
use(input, JSPrecedence.MEMBER_PRECEDENCE);
buffer.add('.');
« no previous file with comments | « frog/leg/emitter.dart ('k') | frog/leg/universe.dart » ('j') | frog/leg/universe.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698