Issue 9667027: Collect is checks to only emit the ones that are needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9667027: Collect is checks to only emit the ones that are needed. (Closed)

Created:
8 years, 9 months ago by ngeoffray

Modified:
8 years, 9 months ago

Reviewers:
ahe, floitsch

CC:
reviews_dartlang.org, karlklose, Lasse Reichstein Nielsen, kasperl

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Collect is checks to only emit the ones that are needed. Committed: https://code.google.com/p/dart/source/detail?r=5283

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -4 lines)			Patch
M	frog/leg/compiler.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	frog/leg/emitter.dart	View		1 chunk	+8 lines, -3 lines	0 comments	Download
M	frog/leg/ssa/codegen.dart	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	frog/leg/universe.dart	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! How much do you save? Cheers, Peter https://chromiumcodereview.appspot.com/9667027/diff/1/frog/leg/universe.dart File frog/leg/universe.dart (right): https://chromiumcodereview.appspot.com/9667027/diff/1/frog/leg/universe.dart#newcode14 frog/leg/universe.dart:14: // ...

8 years, 9 months ago (2012-03-10 15:48:47 UTC) #2

ngeoffray

8 years, 9 months ago (2012-03-10 17:05:40 UTC) #4

Thanks Peter and Florian.

@Peter: around 20k bytes on swarm

https://chromiumcodereview.appspot.com/9667027/diff/1/frog/leg/universe.dart
File frog/leg/universe.dart (right):

https://chromiumcodereview.appspot.com/9667027/diff/1/frog/leg/universe.dart#...
frog/leg/universe.dart:14: // TODO(ngeoffray): This should be a Type.
On 2012/03/10 15:48:47, ahe wrote:
> Type -> Set<Type>

Done.

Expand Messages | Collapse Messages

Issue 9667027: Collect is checks to only emit the ones that are needed. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages