Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/tcmalloc/chromium/src/thread_cache.h

Issue 9667026: Revert 126020 - Experiment for updating the tcmalloc chromium branch to r144 (gperftools 2.0). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/tcmalloc/chromium/src/thread_cache.h
===================================================================
--- third_party/tcmalloc/chromium/src/thread_cache.h (revision 126022)
+++ third_party/tcmalloc/chromium/src/thread_cache.h (working copy)
@@ -88,6 +88,7 @@
void Deallocate(void* ptr, size_t size_class);
void Scavenge();
+ void Print(TCMalloc_Printer* out) const;
int GetSamplePeriod();
@@ -124,6 +125,10 @@
// REQUIRES: Static::pageheap_lock is held.
static void GetThreadStats(uint64_t* total_bytes, uint64_t* class_count);
+ // Write debugging statistics to 'out'.
+ // REQUIRES: Static::pageheap_lock is held.
+ static void PrintThreads(TCMalloc_Printer* out);
+
// Sets the total thread cache size to new_size, recomputing the
// individual thread cache sizes as necessary.
// REQUIRES: Static::pageheap lock is held.
@@ -209,11 +214,6 @@
return FL_Pop(&list_);
}
- void* Next() {
- if (list_ == NULL) return NULL;
- return FL_Next(list_);
- }
-
void PushRange(int N, void *start, void *end) {
FL_PushRange(&list_, start, end);
length_ += N;
@@ -366,12 +366,6 @@
FreeList* list = &list_[cl];
size_ += Static::sizemap()->ByteSizeForClass(cl);
ssize_t size_headroom = max_size_ - size_ - 1;
-
- // This catches back-to-back frees of allocs in the same size
- // class. A more comprehensive (and expensive) test would be to walk
- // the entire freelist. But this might be enough to find some bugs.
- ASSERT(ptr != list->Next());
-
list->Push(ptr);
ssize_t list_headroom =
static_cast<ssize_t>(list->max_length()) - list->length();
« no previous file with comments | « third_party/tcmalloc/chromium/src/tests/thread_dealloc_unittest.cc ('k') | third_party/tcmalloc/chromium/src/thread_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698