Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 9667015: Remove ExtensionMessageService's legacy support for devtools. (Closed)

Created:
8 years, 9 months ago by Matt Perry
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Remove ExtensionMessageService's legacy support for devtools. - Remove OpenSpecialChannelTo*. - Make EMS non-refcounted now that Profile is the sole owner. - Make MessagePorts hold a RenderProcessHost now that processes are the only types of port. I also changed it to hold a process instead of a RenderViewHost, which doesn't make a difference from an IPC messaging standpoint. BUG=104625 TEST=no Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126225

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -125 lines) Patch
M chrome/browser/extensions/extension_devtools_bridge.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_service.h View 6 chunks +8 lines, -43 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 13 chunks +21 lines, -76 lines 1 comment Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +1 line, -4 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
Matt Perry
Yoyo: please review yurys, sdoyon, pfeldman: FYI. I figured thanks to http://codereview.chromium.org/8635005/ that OpenSpecialChannel was ...
8 years, 9 months ago (2012-03-09 23:01:41 UTC) #1
Yoyo Zhou
On 2012/03/09 23:01:41, Matt Perry wrote: > Yoyo: please review > yurys, sdoyon, pfeldman: FYI. ...
8 years, 9 months ago (2012-03-10 01:05:46 UTC) #2
Yoyo Zhou
http://codereview.chromium.org/9667015/diff/1/chrome/browser/extensions/extension_message_service.cc File chrome/browser/extensions/extension_message_service.cc (right): http://codereview.chromium.org/9667015/diff/1/chrome/browser/extensions/extension_message_service.cc#newcode135 chrome/browser/extensions/extension_message_service.cc:135: ExtensionMessageService::ExtensionMessageService(Profile* profile) { Apparently you no longer need this ...
8 years, 9 months ago (2012-03-10 01:36:54 UTC) #3
Yoyo Zhou
LGTM https://chromiumcodereview.appspot.com/9667015/diff/1/chrome/browser/profiles/profile_impl.cc File chrome/browser/profiles/profile_impl.cc (right): https://chromiumcodereview.appspot.com/9667015/diff/1/chrome/browser/profiles/profile_impl.cc#newcode447 chrome/browser/profiles/profile_impl.cc:447: extension_message_service_.reset(new ExtensionMessageService(this)); On 2012/03/10 01:36:54, Yoyo Zhou wrote: ...
8 years, 9 months ago (2012-03-12 18:33:51 UTC) #4
Matt Perry
miranda: can I get an OWNERS lgtm for chrome/browser/profiles ?
8 years, 9 months ago (2012-03-12 21:06:33 UTC) #5
Miranda Callahan
On 2012/03/12 21:06:33, Matt Perry wrote: > miranda: can I get an OWNERS lgtm for ...
8 years, 9 months ago (2012-03-12 21:07:49 UTC) #6
Matt Perry
Thanks!
8 years, 9 months ago (2012-03-12 21:15:13 UTC) #7
pfeldman
Did you use the right bug for this? Note, that all this extension_devtools_bridge business was ...
8 years, 9 months ago (2012-03-13 17:56:37 UTC) #8
Matt Perry
8 years, 9 months ago (2012-03-13 19:17:39 UTC) #9
On 2012/03/13 17:56:37, pfeldman wrote:
> Did you use the right bug for this?

Do you know of a better bug to link here? I used the same one as what was used
in the removal of the extension_ports_service.

> Note, that all this
> extension_devtools_bridge business was created for the timeline / speedtracer
> API. We are deprecating it and it'll be removed in M20.

I'm not familiar enough with the devtools stuff to know what this means. Will it
have an impact on ExtensionMessageService?

Powered by Google App Engine
This is Rietveld 408576698