Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 9667013: DOMStorageMessageFilter implementation that utilizes the new dom_storage classes. (Closed)

Created:
8 years, 9 months ago by michaeln
Modified:
8 years, 9 months ago
Reviewers:
jam, jsbell
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, benm (inactive)
Visibility:
Public.

Description

DOMStorageMessageFilter implementation that utilizes the new dom_storage classes. This class is not yet used, it's behind the ENABLE_NEW_DOM_STORAGE_BACKEND flag which is not defined. The _new filenames are temporary, once the transition is complete they'll be renamed. BUG=106763 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127025

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -199 lines) Patch
A content/browser/dom_storage/OWNERS View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A + content/browser/dom_storage/dom_storage_message_filter_new.h View 1 2 3 4 5 6 7 2 chunks +58 lines, -50 lines 0 comments Download
A + content/browser/dom_storage/dom_storage_message_filter_new.cc View 1 2 3 4 5 6 7 2 chunks +131 lines, -149 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
michaeln
ptal This change depends on https://chromiumcodereview.appspot.com/9665014/ which redefines BrowserMessageFilter's OverrideThreadForMessage method. I'll start work on ...
8 years, 9 months ago (2012-03-10 00:35:51 UTC) #1
michaeln
This change also depends on https://chromiumcodereview.appspot.com/9689033/ which derives DomStorageTaskRunner from base::TaskRunner.
8 years, 9 months ago (2012-03-12 21:49:08 UTC) #2
michaeln
josh, can you take a look at this one?
8 years, 9 months ago (2012-03-13 01:15:32 UTC) #3
jsbell
lgtm (I can't say I'm a fan of pointers for out values vs. references, but ...
8 years, 9 months ago (2012-03-13 18:45:30 UTC) #4
michaeln
actually more than convention, that's explicitly called for in our style guide (inherited from google3's ...
8 years, 9 months ago (2012-03-13 19:01:49 UTC) #5
michaeln
@jam for /content owner
8 years, 9 months ago (2012-03-14 20:27:27 UTC) #6
jam
lgtm
8 years, 9 months ago (2012-03-15 01:32:18 UTC) #7
michaeln
8 years, 9 months ago (2012-03-15 23:37:54 UTC) #8
other files inadvertently got committed with this change (looks like they got
picked up because of the svn add of the new content/dom_storage directory)

the other files have not been added to the gypi file and shouldn't affect the
build at all, so i don't expect this to be a problem, but it was not my intent
to commit those other files with this CL

Powered by Google App Engine
This is Rietveld 408576698