third_party/tcmalloc/chromium/src/base/spinlock_win32-inl.h - Issue 9666033: Experiment for updating the tcmalloc chromium branch to r144 (gperftools 2.0).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/tcmalloc/chromium/src/base/spinlock_win32-inl.h

Issue 9666033: Experiment for updating the tcmalloc chromium branch to r144 (gperftools 2.0). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/tcmalloc/chromium/src/base/spinlock_posix-inl.h ('k') | third_party/tcmalloc/chromium/src/base/stl_allocator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/tcmalloc/chromium/src/base/spinlock_win32-inl.h

diff --git a/third_party/tcmalloc/chromium/src/base/spinlock_win32-inl.h b/third_party/tcmalloc/chromium/src/base/spinlock_win32-inl.h

index ee23541c3e7040f21b65ed2c9e973ab15f6993c5..9e77311c86a0c91687704284fe37107baeb2229b 100644

--- a/third_party/tcmalloc/chromium/src/base/spinlock_win32-inl.h

+++ b/third_party/tcmalloc/chromium/src/base/spinlock_win32-inl.h

@@ -42,6 +42,13 @@ void SpinLockDelay(volatile Atomic32 *w, int32 value, int loop) {

} else if (loop == 1) {

Sleep(0);

} else {

+ // TODO(dmikurube): Re-enable the commented-out code.

+ // We commented out the following line and used the old code "Sleep(1)"

+ // since base/atomicops-internals-windows.h doesn't support 64-bit

+ // operations.

+ //

+ // Commended-out code:

+ // Sleep(base::internal::SuggestedDelayNS(loop) / 1000000);

Sleep(1);

}