Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 9666029: [uber] pack extension overlay (Closed)

Created:
8 years, 9 months ago by Evan Stade
Modified:
8 years, 9 months ago
Reviewers:
csilv
CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), mihaip+watch_chromium.org
Visibility:
Public.

Description

[uber] pack extension overlay when done packing an extension, close the overlay rather than going back to pack extension overlay BUG=116459 TEST=pack an extension (successfully). Press ok. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126195

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/extensions/pack_extension_overlay.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
8 years, 9 months ago (2012-03-10 00:27:03 UTC) #1
csilv
lgtm
8 years, 9 months ago (2012-03-10 00:45:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/9666029/1
8 years, 9 months ago (2012-03-10 00:51:46 UTC) #3
commit-bot: I haz the power
Try job failure for 9666029-1 (retry) (retry) on win_rel for step "browser_tests". It's a second ...
8 years, 9 months ago (2012-03-10 04:59:39 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-12 19:56:12 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698