Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 9666026: Making sure all dirs have OWNERS ... add some to sql/. (Closed)

Created:
8 years, 9 months ago by Dirk Pranke
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A sql/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
I'm guessing as to the best owners here. Feel free to suggest others.
8 years, 9 months ago (2012-03-09 23:12:55 UTC) #1
Scott Hess - ex-Googler
Yeah, I'm LGTM. I'll let the others speak for themselves, though the code gets little ...
8 years, 9 months ago (2012-03-10 00:39:57 UTC) #2
erikwright (departed)
I gather that the point of this is that we will remove '*' from src/OWNERS? ...
8 years, 9 months ago (2012-03-10 01:31:57 UTC) #3
Dirk Pranke
On 2012/03/10 01:31:57, erikwright wrote: > I gather that the point of this is that ...
8 years, 9 months ago (2012-03-12 20:54:06 UTC) #4
erikwright (departed)
8 years, 9 months ago (2012-03-13 14:14:17 UTC) #5
On 2012/03/12 20:54:06, Dirk Pranke wrote:
> On 2012/03/10 01:31:57, erikwright wrote:
> > I gather that the point of this is that we will remove '*' from src/OWNERS?
> > In that case, I'm more than happy to be in here as a backstop in case shess
> > or someone else isn't available, but by default I'll punt to him.
> > 
> > If gbillock is more knowledgeable of this code and he + shess feel
> > sufficient, I'm happy to be left out.
> > 
> 
> Yup, that's the idea :).
> 
> -- Dirk

LGTM.

Powered by Google App Engine
This is Rietveld 408576698