Issue 9666015: Update analysis to support adjacent string literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9666015: Update analysis to support adjacent string literals (Closed)

Created:
8 years, 9 months ago by zundel

Modified:
8 years, 9 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
reviews_dartlang.org, Ivan Posva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update analysis to support adjacent string literals http://code.google.com/p/dart/issues/detail?id=2079 Committed: https://code.google.com/p/dart/source/detail?r=5255

Patch Set 1 : Add back ICE #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+265 lines, -47 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	10 chunks	+145 lines, -38 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	2 chunks	+115 lines, -7 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zundel

Here is one way to incorporate the new 'adjacent string' feature that replaces string concatenation ...

8 years, 9 months ago (2012-03-09 21:18:02 UTC) #1

Brian Wilkerson

8 years, 9 months ago (2012-03-09 21:38:20 UTC) #4

I think we should get this in as is for now to fix the immediate problems, but
long term we need to create a new AST node to represent this kind of structure
so that we know where the individual strings are located in the source.

Expand Messages | Collapse Messages