Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 9665032: If a test aborted (e.g. ASSERT_EQ() failure) with a TemplateURLFetcher running, shutdown would go b… (Closed)

Created:
8 years, 9 months ago by Peter Kasting
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

If a test aborted (e.g. ASSERT_EQ() failure) with a TemplateURLFetcher running, shutdown would go badly, leading to a DCHECK failure. In the real browser this isn't an issue because the URLFetchers are shut down correctly, but in the TestingProfile we don't have all the same shutdown machinery so resetting the TemplateURLFetcher explicitly avoids the potential problem. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/test/base/testing_profile.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
Will, this is the belated review for a fix we discussed in email almost a ...
8 years, 9 months ago (2012-03-10 01:39:20 UTC) #1
willchan no longer on Chromium
8 years, 9 months ago (2012-03-12 20:34:39 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698