chrome/browser/sync/profile_sync_service_factory.cc - Issue 9665007: Profile refactoring: Remove all PasswordStore code from the Profile interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_factory.cc

Issue 9665007: Profile refactoring: Remove all PasswordStore code from the Profile interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add to factory list Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_autofill_unittest.cc ('k') | chrome/browser/sync/profile_sync_service_password_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_factory.cc

diff --git a/chrome/browser/sync/profile_sync_service_factory.cc b/chrome/browser/sync/profile_sync_service_factory.cc

index b0fa3617cbfb294d86eec71af965e162638f3406..bf4cfbffd702c107a1a92a091d6e9c5382b9a703 100644

--- a/chrome/browser/sync/profile_sync_service_factory.cc

+++ b/chrome/browser/sync/profile_sync_service_factory.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/prefs/pref_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_dependency_manager.h"

+#include "chrome/browser/password_manager/password_store_factory.h"

#include "chrome/browser/search_engines/template_url_service_factory.h"

#include "chrome/browser/sessions/tab_restore_service_factory.h"

#include "chrome/browser/signin/signin_manager.h"

@@ -48,6 +49,7 @@ ProfileSyncServiceFactory::ProfileSyncServiceFactory()

DependsOn(ThemeServiceFactory::GetInstance());

DependsOn(GlobalErrorServiceFactory::GetInstance());

DependsOn(SigninManagerFactory::GetInstance());

+ DependsOn(PasswordStoreFactory::GetInstance());

// The following have not been converted to ProfileKeyedServices yet, and for

// now they are explicitly destroyed after the ProfileDependencyManager is

@@ -58,7 +60,6 @@ ProfileSyncServiceFactory::ProfileSyncServiceFactory()

// DependsOn(HistoryServiceFactory::GetInstance());

// DependsOn(BookmarkBarModelFactory::GetInstance());

// DependsOn(FaviconServiceFactory::GetInstance());

- // DependsOn(PasswordStoreService::GetInstance());

// DependsOn(ExtensionServiceFactory::GetInstance());

}