Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 9664072: Removing WmIpc and related files from ChromeOS (Closed)

Created:
8 years, 9 months ago by Emmanuel Saint-loubert-Bié
Modified:
8 years, 9 months ago
Reviewers:
xiyuan, DaveMoore, sky
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Some ChromeOS GTK cleanup: removing WmIpc and related files. And a few orphan files found in the process. This is to be landed after R18 goes stable, and ideally before R19 branches. TBR=DaveMoore@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127479

Patch Set 1 #

Patch Set 2 : Re-added file dep #

Patch Set 3 : Merge #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Merge #

Patch Set 7 : Fix browser test #

Patch Set 8 : Merge #

Patch Set 9 : Merge #

Patch Set 10 : Copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6486 lines) Patch
D chrome/browser/chromeos/frame/browser_view.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -643 lines 0 comments Download
M chrome/browser/chromeos/frame/layout_mode_button.cc View 1 2 3 4 5 6 7 8 9 3 chunks +1 line, -47 lines 0 comments Download
D chrome/browser/chromeos/frame/panel_browser_view.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/chromeos/frame/panel_browser_view.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D chrome/browser/chromeos/frame/panel_controller.h View 1 chunk +0 lines, -182 lines 0 comments Download
D chrome/browser/chromeos/frame/panel_controller.cc View 1 2 3 1 chunk +0 lines, -492 lines 0 comments Download
D chrome/browser/chromeos/legacy_window_manager/wm_ipc.h View 1 chunk +0 lines, -181 lines 0 comments Download
D chrome/browser/chromeos/legacy_window_manager/wm_ipc.cc View 1 chunk +0 lines, -315 lines 0 comments Download
D chrome/browser/chromeos/legacy_window_manager/wm_message_listener.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/chromeos/legacy_window_manager/wm_message_listener.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.cc View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -9 lines 0 comments Download
D chrome/browser/chromeos/login/lock_window_gtk.h View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/chromeos/login/lock_window_gtk.cc View 1 chunk +0 lines, -319 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/chromeos/login/screen_locker_browsertest.cc View 1 2 3 4 5 1 chunk +0 lines, -347 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -9 lines 0 comments Download
D chrome/browser/chromeos/login/username_view.cc View 1 2 3 1 chunk +0 lines, -151 lines 0 comments Download
M chrome/browser/chromeos/login/version_info_updater.cc View 1 2 3 4 5 6 7 8 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 2 chunks +0 lines, -12 lines 0 comments Download
D chrome/browser/chromeos/notifications/balloon_collection_impl.h View 1 chunk +0 lines, -149 lines 0 comments Download
D chrome/browser/chromeos/notifications/balloon_collection_impl.cc View 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/browser/chromeos/notifications/balloon_view.h View 1 chunk +0 lines, -127 lines 0 comments Download
D chrome/browser/chromeos/notifications/balloon_view.cc View 1 2 3 1 chunk +0 lines, -375 lines 0 comments Download
D chrome/browser/chromeos/notifications/desktop_notifications_unittest.h View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc View 1 chunk +0 lines, -323 lines 0 comments Download
D chrome/browser/chromeos/notifications/notification_browsertest.cc View 1 chunk +0 lines, -594 lines 0 comments Download
D chrome/browser/chromeos/notifications/notification_panel.h View 1 chunk +0 lines, -247 lines 0 comments Download
D chrome/browser/chromeos/notifications/notification_panel.cc View 1 chunk +0 lines, -897 lines 0 comments Download
D chrome/browser/chromeos/notifications/system_notification_browsertest.cc View 1 chunk +0 lines, -154 lines 0 comments Download
M chrome/browser/chromeos/panels/panel_browsertest.cc View 2 chunks +0 lines, -13 lines 0 comments Download
D chrome/browser/chromeos/xinput_hierarchy_changed_event_listener_gtk.cc View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/window.cc View 3 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 8 chunks +0 lines, -50 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 4 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Emmanuel Saint-loubert-Bié
sky: chrome/browser/ui xiyuan: chrome/browser/ui/webui/chromeos davemoore: everything else :-) BTW I am not entirely sure how ...
8 years, 9 months ago (2012-03-14 00:21:59 UTC) #1
sky
I'm all for removing code, but should we wait until we're sure on aura in ...
8 years, 9 months ago (2012-03-14 03:47:58 UTC) #2
xiyuan
LGTM
8 years, 9 months ago (2012-03-14 03:50:50 UTC) #3
Ben Goodger (Google)
On 2012/03/14 03:47:58, sky wrote: > I'm all for removing code, but should we wait ...
8 years, 9 months ago (2012-03-14 03:52:17 UTC) #4
sky
Nice! Rubber stamp LGTM
8 years, 9 months ago (2012-03-14 04:44:16 UTC) #5
Emmanuel Saint-loubert-Bié
8 years, 9 months ago (2012-03-16 21:29:01 UTC) #6
Dave,

Friendly ping :-)

-- Emmanuel

Powered by Google App Engine
This is Rietveld 408576698