Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 9664068: removed unused 'chromium' component (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index b69f78a8d036c5d49f9e2dd8bf9e30dcf1415aee..90d3d1ed798cd2b34622c5fb47cd642328752471 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -327,7 +327,6 @@ class StandardTestSuite implements TestSuite {
switch (configuration['component']) {
case 'dartium':
- case 'chromium':
case 'frogium':
case 'legium':
case 'webdriver':
@@ -575,14 +574,6 @@ class StandardTestSuite implements TestSuite {
String executable = TestUtils.compilerPath(configuration);
List<String> args = TestUtils.standardOptions(configuration);
switch (component) {
- // TODO(zundel): Remove chromium now that dartc doesn't generate code?
- case 'chromium':
- args.addAll(['--work', dir]);
- args.addAll(vmOptions);
- args.add('--ignore-unrecognized-flags');
- args.add(inputFile);
- // TODO(whesse): Add --fatal-type-errors if needed.
- break;
case 'frogium':
case 'legium':
case 'webdriver':
@@ -603,8 +594,7 @@ class StandardTestSuite implements TestSuite {
}
bool get requiresCleanTemporaryDirectory() =>
- configuration['component'] == 'dartc' ||
- configuration['component'] == 'chromium';
+ configuration['component'] == 'dartc';
/**
* Create a directory for the generated test. If a Dart language test
@@ -673,7 +663,6 @@ class StandardTestSuite implements TestSuite {
switch (configuration['component']) {
case 'dartium':
return 'application/dart';
- case 'chromium':
case 'frogium':
case 'legium':
case 'webdriver':
@@ -1099,7 +1088,6 @@ class TestUtils {
static String compilerName(Map configuration) {
String suffix = executableSuffix(configuration['component']);
switch (configuration['component']) {
- case 'chromium':
case 'dartc':
return 'compiler/bin/dartc$suffix';
case 'frogium':
« tools/testing/dart/test_options.dart ('K') | « tools/testing/dart/test_options.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698