Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 9664028: Exception handling: Split test so that it can be separately enabled/disabled (Closed)

Created:
8 years, 9 months ago by Mark Seaborn
Modified:
8 years, 9 months ago
Reviewers:
bradn
CC:
native-client-reviews_googlegroups.com, halyavin
Visibility:
Public.

Description

Exception handling: Split test so that it can be separately enabled/disabled This enables the test for exception handling for NaCl-in-Chromium but gives it a separate name, 'run_inbrowser_exception_test', so that it can be disabled from Chromium's buildbot_nacl_integration.py script until exception handling support is implemented on the Chromium side on all platforms. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2602 TEST=none Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8002

Patch Set 1 #

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -42 lines) Patch
M tests/inbrowser_test_runner/nacl.scons View 1 1 chunk +45 lines, -42 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
This goes with https://chromiumcodereview.appspot.com/9688017/
8 years, 9 months ago (2012-03-12 16:39:50 UTC) #1
bradn
LGTM Do we want to do anything about inbrowser_untrusted_crash_dump in this regard? It should always ...
8 years, 9 months ago (2012-03-12 17:42:35 UTC) #2
Mark Seaborn
8 years, 9 months ago (2012-03-12 21:39:18 UTC) #3
On 12 March 2012 10:42, <bradnelson@google.com> wrote:

> LGTM
> Do we want to do anything about inbrowser_untrusted_crash_dump in this
> regard?
> It should always be via external sel_ldr so probably not.
>

No, I'm not worried about enabling that in NaCl-in-Chromium yet.
exception_test is the main thing I need for testing Chromium-side changes.

Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

Powered by Google App Engine
This is Rietveld 408576698