Issue 9664020: Add wildcard OWNERS files for directories where anyone can approve commits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9664020: Add wildcard OWNERS files for directories where anyone can approve commits. (Closed)

Created:
8 years, 9 months ago by Dirk Pranke

Modified:
8 years, 9 months ago

Reviewers:
darin (slow to review), Ben Goodger (Google)

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add wildcard OWNERS files for directories where anyone can approve commits. R=ben@chromium.org, darin@chromium.org BUG=88315 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126218

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -0 lines)			Patch
A	build/OWNERS	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	third_party/OWNERS	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/OWNERS	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Part of my changes to remove (?) the top-level wildcard and make sure there are ...

8 years, 9 months ago (2012-03-09 23:04:55 UTC) #1

Ben Goodger (Google)

8 years, 9 months ago (2012-03-09 23:20:34 UTC) #3

LGTM2

On Fri, Mar 9, 2012 at 3:18 PM, <darin@chromium.org> wrote:

> LGTM
>
>
https://chromiumcodereview.**appspot.com/9664020/<https://chromiumcodereview....
>

Expand Messages | Collapse Messages