Issue 9664018: Per recent discussion on chromium-dev@, we are going to disallow nested "set noparent" OWNERS files…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9664018: Per recent discussion on chromium-dev@, we are going to disallow nested "set noparent" OWNERS files… (Closed)

Created:
8 years, 9 months ago by Dirk Pranke

Modified:
8 years, 9 months ago

Reviewers:
Albert Bodenhamer, darin (slow to review), Ben Goodger (Google), akalin

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, arv (Not doing code reviews), jam, Albert Bodenhamer, akalin, Andrew T Wilson (Slow), battre, dpapad, eroman, gene, jar (doing other things), kmadhusu, lipalani1, mmenke, ncarter (slow), Randy Smith (Not in Mondays), rlarocque, Raghu Simha, Scott Byer, Lei Zhang, tim (not reviewing), vandebo (ex-Chrome), willchan no longer on Chromium, wtc, Nicolas Zea

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Per recent discussion on chromium-dev@, we are going to disallow nested "set noparent" OWNERS files (as a move to eliminating "set noparent" more generally). R=ben@chromium.org BUG=117607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126286

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -4 lines)			Patch
M	chrome/browser/printing/cloud_print/OWNERS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/sync_internals/OWNERS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/print_preview/OWNERS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/net/OWNERS	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Those of you on the CC: line, this is an FYI that the "set noparent" ...

8 years, 9 months ago (2012-03-09 22:45:37 UTC) #1

LGTM

Expand Messages | Collapse Messages