Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1741)

Unified Diff: trychange.py

Issue 9664015: Adds saner behavior for git try -t foo to not fail in a inexplicable way. Enforces that each builde… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/presubmit_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index 748dbfa6cd45f90c68ab69fcc255f238645fe3e3..9c449ae49524e44661fced57c01080de0abe2c16 100755
--- a/trychange.py
+++ b/trychange.py
@@ -805,6 +805,16 @@ def TryChange(argv,
sys.stdout)
except ImportError:
pass
+ if options.testfilter:
+ bots = set()
+ for bot in options.bot:
+ assert ',' not in bot
+ if bot.endswith(':compile'):
+ # Strip it.
Peter Mayo 2012/03/10 00:30:13 This comment is not clear - the code says skip the
M-A Ruel 2012/03/10 01:40:45 For now I'll keep it this way but I'll probably re
+ continue
+ bots.add(bot.split(':', 1)[0])
+ options.bot = list(bots)
+
# If no bot is specified, either the default pool will be selected or the
# try server will refuse the job. Either case we don't need to interfere.
« no previous file with comments | « tests/presubmit_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698