Issue 9664013: Hide daemon UI initially.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9664013: Hide daemon UI initially. (Closed)

Created:
8 years, 9 months ago by Jamie

Modified:
8 years, 9 months ago

Reviewers:
garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Hide daemon UI initially. BUG=117555 TEST=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126208

Patch Set 1 #

Patch Set 2 : Continue initialization after cancelling me2me. #

Total comments: 2

Patch Set 3 : Refactored to minimize 'secondary' init code. #

Patch Set 4 : rebase #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -11 lines)			Patch
M	remoting/webapp/client_screen.js	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download
M	remoting/webapp/main.html	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/webapp/remoting.js	View	1 2	2 chunks	+14 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jamie

The previous patch left the ChromeOS-only UI uninitialised.

8 years, 9 months ago (2012-03-12 19:14:02 UTC) #2

garykac

lgtm http://codereview.chromium.org/9664013/diff/3001/remoting/webapp/remoting.js File remoting/webapp/remoting.js (right): http://codereview.chromium.org/9664013/diff/3001/remoting/webapp/remoting.js#newcode77 remoting/webapp/remoting.js:77: if (isHostModeSupported_()) { As discussed: you can move ...

8 years, 9 months ago (2012-03-12 20:03:11 UTC) #3

Jamie

8 years, 9 months ago (2012-03-14 18:47:11 UTC) #4

FYI

https://chromiumcodereview.appspot.com/9664013/diff/3001/remoting/webapp/remo...
File remoting/webapp/remoting.js (right):

https://chromiumcodereview.appspot.com/9664013/diff/3001/remoting/webapp/remo...
remoting/webapp/remoting.js:77: if (isHostModeSupported_()) {
On 2012/03/12 20:03:12, garykac wrote:
> As discussed: you can move these back into init().

Done.

Expand Messages | Collapse Messages