Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: frog/scripts/buildbot_annotated_steps.py

Issue 9663028: make test.py invoked under xvfb-runw (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/frogpad/frogpad.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/scripts/buildbot_annotated_steps.py
diff --git a/frog/scripts/buildbot_annotated_steps.py b/frog/scripts/buildbot_annotated_steps.py
index 761ef8f81c88ccbb70648c46c1c0d85e9a3abe05..b6f047d2f81e296567008335611f1bf2d07f73b6 100644
--- a/frog/scripts/buildbot_annotated_steps.py
+++ b/frog/scripts/buildbot_annotated_steps.py
@@ -63,13 +63,13 @@ def GetBuildInfo():
return (name, mode, system, browser)
-def IsWebComponent(component):
- return component in ['frogium', 'webdriver', 'legium']
+def ComponentsNeedsXterm(component):
+ return component in ['frogsh', 'frogium', 'legium', 'webdriver']
def TestStep(name, mode, system, component, targets, flags):
print '@@@BUILD_STEP %s tests: %s %s@@@' % (name, component, ' '.join(flags))
sys.stdout.flush()
- if IsWebComponent(component) and system == 'linux':
+ if ComponentsNeedsXterm(component) and system == 'linux':
cmd = ['xvfb-run', '-a']
else:
cmd = []
« no previous file with comments | « no previous file | tools/testing/frogpad/frogpad.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698