Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: tools/testing/frogpad/frogpad.py

Issue 9663024: now use xvfb (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/frogpad/frogpad.py
diff --git a/tools/testing/frogpad/frogpad.py b/tools/testing/frogpad/frogpad.py
index 17718393f080a1de732dd938eedd1f245d677249..3cfe44173574ebc83d3a25e60091e10ffebfac2d 100755
--- a/tools/testing/frogpad/frogpad.py
+++ b/tools/testing/frogpad/frogpad.py
@@ -31,6 +31,7 @@ have the generated javascript.
import logging
import optparse
import os.path
+import platform
import re
import subprocess
import sys
@@ -170,8 +171,6 @@ class Pad(object):
logging.debug("frog_dir: '%s'" % self.frog_dir)
logging.debug("frogpad_dir: '%s'" % self.frogpad_dir)
- logging.info("cwd '%s'" % os.getcwd())
-
# location of frogpad.js
if not options.frogpad_js:
raise Exception("--frogpad_js is required")
@@ -229,6 +228,11 @@ class Pad(object):
def generate_js(self):
drt = os.path.join(self.dart_dir, "client/tests/drt/DumpRenderTree")
+ if platform.system() == 'Darwin':
+ drt += ".app"
+ elif platform.system() == 'Windows':
+ raise Exception("frogpad does not run on Windows")
+
check_exists(drt)
args = []
args.append(drt)
@@ -340,7 +344,7 @@ def run_command(args):
"""
command = format_command(args)
- logging.debug("RUNNING " + command)
+ logging.info("RUNNING: '%s'" % command)
child = subprocess.Popen(args,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698