net: add OCSP tests.

net/url_request/url_request_unittest.cc

Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index c0cbbf6eac282450f1faf942adcfebcd1e94ebad..9f7b367ab3da4b9294870d04a23b96c62118bb4e 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -27,6 +27,7 @@
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
+#include "net/base/cert_test_util.h"
 #include "net/base/cookie_monster.h"
 #include "net/base/cookie_store_test_helpers.h"
 #include "net/base/load_flags.h"
@@ -37,6 +38,7 @@
 #include "net/base/net_module.h"
 #include "net/base/net_util.h"
 #include "net/base/ssl_connection_status_flags.h"
+#include "net/base/test_root_certs.h"
 #include "net/base/upload_data.h"
 #include "net/disk_cache/disk_cache.h"
 #include "net/ftp/ftp_network_layer.h"
@@ -45,6 +47,7 @@
 #include "net/http/http_network_session.h"
 #include "net/http/http_request_headers.h"
 #include "net/http/http_response_headers.h"
+#include "net/ocsp/nss_ocsp.h"
 #include "net/proxy/proxy_service.h"
 #include "net/socket/ssl_client_socket.h"
 #include "net/test/test_server.h"
@@ -1367,6 +1370,100 @@ TEST_F(HTTPSRequestTest, HTTPSExpiredTest) {
   }
 }
 
+class RevCheckedEnabledSSLConfigService : public SSLConfigService {
+ public:
+  virtual void GetSSLConfig(SSLConfig* config) {
+    *config = SSLConfig();
+    config->rev_checking_enabled = true;
+    config->verify_ev_cert = true;
+  }
+};
+
+class HTTPSOCSPTest : public HTTPSRequestTest {
+ public:
+  HTTPSOCSPTest()
+      : context_(new TestURLRequestContext(true)) {
+    context_->set_ssl_config_service(new RevCheckedEnabledSSLConfigService);
+    context_->Init();
+
+    scoped_refptr<net::X509Certificate> root_cert =
+      ImportCertFromFile(GetTestCertsDirectory(), "ocsp-test-root.pem");
+    CHECK_NE(static_cast<X509Certificate*>(NULL), root_cert);
+    test_root_.reset(new ScopedTestRoot(root_cert));
+
+#if defined(USE_NSS)
+    EnsureOCSPInit();
+    SetURLRequestContextForOCSP(context_.get());
+#endif
+  }
+
+  void DoConnection(const TestServer::HTTPSOptions& https_options,
+                    CertStatus* out_cert_status) {
+    TestServer test_server(https_options,
+                           FilePath(FILE_PATH_LITERAL("net/data/ssl")));
+    ASSERT_TRUE(test_server.Start());
+
+    TestDelegate d;
+    d.set_allow_certificate_errors(true);
+    URLRequest r(test_server.GetURL(""), &d);
+    r.set_context(context_.get());
+    r.Start();
+
+    MessageLoop::current()->Run();
+
+    EXPECT_EQ(1, d.response_started_count());
+    *out_cert_status = r.ssl_info().cert_status;
+  }
+
+ private:
+  scoped_ptr<ScopedTestRoot> test_root_;
+  scoped_refptr<TestURLRequestContext> context_;
+};
+
+#if !defined(OS_ANDROID) && !defined(USE_OPENSSL)
+// TODO(jnd): http://crbug.com/117478 - EV verification is not yet supported.
+TEST_F(HTTPSOCSPTest, OCSPValid) {
+  TestServer::HTTPSOptions https_options(TestServer::HTTPSOptions::OCSP_OK);
+
+  CertStatus cert_status;
+  DoConnection(https_options, &cert_status);
+  EXPECT_EQ(0u, cert_status & CERT_STATUS_ALL_ERRORS);
+  EXPECT_TRUE(cert_status & CERT_STATUS_IS_EV);
+  EXPECT_TRUE(cert_status & CERT_STATUS_REV_CHECKING_ENABLED);
+}
+
+TEST_F(HTTPSOCSPTest, OCSPRevoked) {
+  TestServer::HTTPSOptions https_options(
+      TestServer::HTTPSOptions::OCSP_REVOKED);
+
+  CertStatus cert_status;
+  DoConnection(https_options, &cert_status);
+  EXPECT_EQ(CERT_STATUS_REVOKED, cert_status & CERT_STATUS_ALL_ERRORS);
+  EXPECT_FALSE(cert_status & CERT_STATUS_IS_EV);
+  EXPECT_TRUE(cert_status & CERT_STATUS_REV_CHECKING_ENABLED);
+}
+
+TEST_F(HTTPSOCSPTest, OCSPInvalid) {
+  TestServer::HTTPSOptions https_options(
+      TestServer::HTTPSOptions::OCSP_INVALID);
+
+  CertStatus cert_status;
+  DoConnection(https_options, &cert_status);
+  // Windows can return CERT_STATUS_UNABLE_TO_CHECK_REVOCATION but we don't
+  // have that ability on other platforms.

[Ryan Sleevi, 2012/03/09 22:07:53]

For OS X, we should. What errors are you seeing?

[agl, 2012/03/13 22:24:29]

I think the test passed on Mac when I tried it. Certainly I'll try it again
before landing, but Mac doesn't appear to set
CERT_STATUS_UNABLE_TO_CHECK_REVOCATION.

+#if defined(OS_WIN)
+  EXPECT_EQ(CERT_STATUS_UNABLE_TO_CHECK_REVOCATION,
+            cert_status & CERT_STATUS_ALL_ERRORS);
+#else
+  EXPECT_EQ(0u, cert_status & CERT_STATUS_ALL_ERRORS);
+#endif
+
+  // Without a positive OCSP response, we shouldn't show the EV status.
+  EXPECT_FALSE(cert_status & CERT_STATUS_IS_EV);
+  EXPECT_TRUE(cert_status & CERT_STATUS_REV_CHECKING_ENABLED);
+}
+#endif // !OS_ANDROID && !USE_OPENSSL
+
 // This tests that a load of www.google.com with a certificate error sets
 // the |certificate_errors_are_fatal| flag correctly. This flag will cause
 // the interstitial to be fatal.