Issue 9662022: Basic skeleton of a window/layer/view inspector.

Issue 9662022: Basic skeleton of a window/layer/view inspector. (Closed)

Created:
8 years, 9 months ago by Ben Goodger (Google)

Modified:
8 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Basic skeleton of a window/layer/view inspector. Ctrl+Shift+F1 brings it up. http://crbug.com/97266 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126207

Patch Set 1 #

Total comments: 4

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+384 lines, --8 lines)			Patch
M	ash/accelerators/accelerator_controller.cc	View	4 chunks	+7 lines, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_table.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/accelerators/accelerator_table.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/ash.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/ash_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/ash_switches.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	build/all.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	ui/oak/oak.gyp	View	1 chunk	+48 lines, -0 lines	1 comment	Download
A	ui/oak/oak_aura_window_display.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	ui/oak/oak_aura_window_display.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	ui/oak/oak_export.h	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A	ui/oak/oak_layer_display.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	ui/oak/oak_layer_display.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	ui/oak/oak_tree_model.h	View	1 chunk	+28 lines, -0 lines	0 comments	Download
A	ui/oak/oak_tree_model.cc	View	1 chunk	+39 lines, -0 lines	0 comments	Download
A	ui/oak/oak_views_view_display.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	ui/oak/oak_views_view_display.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	ui/oak/oak_views_widget_display.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	ui/oak/oak_views_widget_display.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	ui/oak/oak_window.h	View	1 chunk	+62 lines, -0 lines	1 comment	Download
A	ui/oak/oak_window.cc	View	1 chunk	+156 lines, -0 lines	2 comments	Download
A	ui/resources/oak.png	View	Binary file		0 comments	Download
M	ui/resources/ui_resources.grd	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

8 years, 9 months ago (2012-03-10 14:42:46 UTC) #3

http://codereview.chromium.org/9662022/diff/1/ui/oak/oak.gyp
File ui/oak/oak.gyp (right):

http://codereview.chromium.org/9662022/diff/1/ui/oak/oak.gyp#newcode30
ui/oak/oak.gyp:30: # All .cc, .h under ash, except unittests
nit: under ash -> under oak.

http://codereview.chromium.org/9662022/diff/1/ui/oak/oak_window.cc
File ui/oak/oak_window.cc (right):

http://codereview.chromium.org/9662022/diff/1/ui/oak/oak_window.cc#newcode30
ui/oak/oak_window.cc:30: canvas->GetSkCanvas()->drawColor(SK_ColorYELLOW);
nit: canvas->sk_canvas()->drawColor(..);

http://codereview.chromium.org/9662022/diff/1/ui/oak/oak_window.cc#newcode89
ui/oak/oak_window.cc:89: canvas->GetSkCanvas()->drawColor(SK_ColorWHITE);
nit: canvas->sk_canvas()->drawColor(...);

http://codereview.chromium.org/9662022/diff/1/ui/oak/oak_window.h
File ui/oak/oak_window.h (right):

http://codereview.chromium.org/9662022/diff/1/ui/oak/oak_window.h#newcode24
ui/oak/oak_window.h:24: static views::Widget* instance_;
nit: hum |instance_|? May be |instance|? Or move it to private section and have
an accessor for it?

Expand Messages | Collapse Messages