Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 9662011: Don't run InProcessBrowserTest.Empty when gtest_filter is specified. There are two reasons for this: (Closed)

Created:
8 years, 9 months ago by jam
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Don't run InProcessBrowserTest.Empty when gtest_filter is specified. There are two reasons for this: -when runing one test locally during development, this slows down things a lot -on the trybots when sharding_supervisor is used, this test runs ~200 times and wastes a few minutes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125908

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M content/test/test_launcher.cc View 1 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
If we find that this is actually causing timeouts on trybots for the first test ...
8 years, 9 months ago (2012-03-09 20:27:30 UTC) #1
sky
8 years, 9 months ago (2012-03-09 20:59:45 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698