 Chromium Code Reviews
 Chromium Code Reviews Issue 9662010:
  Don't put private members in dart:html interfaces.  (Closed) 
  Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
    
  
    Issue 9662010:
  Don't put private members in dart:html interfaces.  (Closed) 
  Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart| Index: client/dom/scripts/systemhtml.py | 
| diff --git a/client/dom/scripts/systemhtml.py b/client/dom/scripts/systemhtml.py | 
| index 1df77152234292986eb7ca63a5ef748f4fa1e58f..8c71388818a8b6b4b998b38f541c183b113c301e 100644 | 
| --- a/client/dom/scripts/systemhtml.py | 
| +++ b/client/dom/scripts/systemhtml.py | 
| @@ -666,9 +666,9 @@ class HtmlDartInterfaceGenerator(DartInterfaceGenerator): | 
| html_setter_name = self._shared.RenameInHtmlLibrary( | 
| self._interface, getter.id, 'set:') | 
| - if not html_getter_name: | 
| + if not html_getter_name or html_getter_name.startswith('_'): | 
| 
Jacob
2012/03/09 19:18:39
add a trivial
IsPrivate helper
 
nweiz
2012/03/09 20:58:57
Done.
 | 
| getter = None | 
| - if not html_setter_name: | 
| + if not html_setter_name or html_setter_name.startswith('_'): | 
| setter = None | 
| if not getter and not setter: | 
| return | 
| @@ -697,7 +697,7 @@ class HtmlDartInterfaceGenerator(DartInterfaceGenerator): | 
| name. | 
| """ | 
| html_name = self._shared.RenameInHtmlLibrary(self._interface, info.name) | 
| - if html_name: | 
| + if html_name and not html_name.startswith('_'): | 
| self._members_emitter.Emit('\n' | 
| ' $TYPE $NAME($PARAMS);\n', | 
| TYPE=info.type_name, |