Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 9657021: Use the shared context for ppapi parenting (Closed)

Created:
8 years, 9 months ago by jamesr
Modified:
8 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Use the shared context for ppapi parenting This parents pepper 3d contexts to the shared graphics context and not directly to the compositor context. This has two benefits: 1.) The shared context can be used from the main thread, unlike the compositor context in threaded mode 2.) The shared context is offscreen, so it can be initialized before the view's HWND/whatnot is ready This depends on https://bugs.webkit.org/show_bug.cgi?id=80670 BUG=117125 TEST=load up ppapi/examples/gles2/gles.html with --enable-threaded-compositing. plugin should initialize and render correctly in debug mode with no assertions about incorrect thread use, and the plugin should recover and continue rendering if the GPU process is killed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
piman
lgtm
8 years, 9 months ago (2012-03-09 06:35:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9657021/1
8 years, 9 months ago (2012-03-15 21:06:55 UTC) #2
commit-bot: I haz the power
8 years, 9 months ago (2012-03-16 00:59:39 UTC) #3
Change committed as 127057

Powered by Google App Engine
This is Rietveld 408576698