Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 9657007: Fix the underlying problem for Trunk/ToT build 19.0.1063.0: crash during start (Closed)

Created:
8 years, 9 months ago by jianli
Modified:
8 years, 9 months ago
Reviewers:
jennb
CC:
chromium-reviews, Dmitry Lomov (no reviews), jennb, Dmitry Titov, jianli, dcheng, Andrei
Visibility:
Public.

Description

Fix the underlying problem for Trunk/ToT build 19.0.1063.0: crash during start. The fix is to remove the unintended duplicated observer_ definition in the sub class. BUG=117347 TEST=Manual test to start chrome with auto-hiding taskbar enabled on win Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/panels/display_settings_provider_win.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jianli
8 years, 9 months ago (2012-03-08 21:59:01 UTC) #1
jennb
8 years, 9 months ago (2012-03-08 22:09:42 UTC) #2
LGTM

Add to patch description to explain that this var was duplicating the var in the
base class. Else it's totally non-obvious why this change is the fix.

Powered by Google App Engine
This is Rietveld 408576698