Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: content/renderer/media/audio_renderer_impl.cc

Issue 9655018: Make AudioParameters a class instead of a struct (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_renderer_impl.cc
diff --git a/content/renderer/media/audio_renderer_impl.cc b/content/renderer/media/audio_renderer_impl.cc
index b835e686b95ed5e62412c124fba3d04eb8bbe08c..f84b43428223cbb3d9af851631a2aa92aeb4b157 100644
--- a/content/renderer/media/audio_renderer_impl.cc
+++ b/content/renderer/media/audio_renderer_impl.cc
@@ -60,23 +60,17 @@ bool AudioRendererImpl::OnInitialize(int bits_per_channel,
// does not currently support all the sample-rates that we require.
// Please see: http://code.google.com/p/chromium/issues/detail?id=103627
// for more details.
- audio_parameters_ = AudioParameters(AudioParameters::AUDIO_PCM_LINEAR,
- channel_layout,
- sample_rate,
- bits_per_channel,
- 0);
+ audio_parameters_.Reset(
+ AudioParameters::AUDIO_PCM_LINEAR,
+ channel_layout, sample_rate, bits_per_channel,
+ audio_hardware::GetHighLatencyOutputBufferSize(sample_rate));
bytes_per_second_ = audio_parameters_.GetBytesPerSecond();
DCHECK(sink_.get());
if (!is_initialized_) {
- sink_->Initialize(
- audio_hardware::GetHighLatencyOutputBufferSize(sample_rate),
- audio_parameters_.channels,
- audio_parameters_.sample_rate,
- audio_parameters_.format,
- this);
+ sink_->Initialize(audio_parameters_, this);
sink_->Start();
is_initialized_ = true;
@@ -194,7 +188,7 @@ size_t AudioRendererImpl::Render(const std::vector<float*>& audio_data,
}
uint32 bytes_per_frame =
scherkus (not reviewing) 2012/03/09 21:48:59 isn't there a function on AudioParameters for this
vrk (LEFT CHROMIUM) 2012/03/16 18:30:41 There isn't, but while I'm here I can add one! Mos
- audio_parameters_.bits_per_sample * audio_parameters_.channels / 8;
+ audio_parameters_.bits_per_sample() * audio_parameters_.channels() / 8;
const size_t buf_size = number_of_frames * bytes_per_frame;
scoped_array<uint8> buf(new uint8[buf_size]);

Powered by Google App Engine
This is Rietveld 408576698