Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: client/dom/scripts/systemhtml.py

Issue 9653009: Fix build breakage caused by commit 5196. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/scripts/systemhtml.py
diff --git a/client/dom/scripts/systemhtml.py b/client/dom/scripts/systemhtml.py
index 18b8d533839cbac7f04db58e488cc1a56f6c1808..50002e1c7dbee0c66ee5f47c13ef7850adc6f8d2 100644
--- a/client/dom/scripts/systemhtml.py
+++ b/client/dom/scripts/systemhtml.py
@@ -728,9 +728,9 @@ class HtmlDartInterfaceGenerator(DartInterfaceGenerator):
else:
raise Exception('No known html even name for event: ' + event_name)
- def _EmitEventGetter(self, interface):
+ def _EmitEventGetter(self, events_interface):
self._members_emitter.Emit('\n $TYPE get on();\n',
- TYPE=interface)
+ TYPE=events_interface)
# ------------------------------------------------------------------------------
@@ -799,7 +799,8 @@ class HtmlFrogClassGenerator(FrogInterfaceGenerator):
elif events:
self.AddEventAttributes(events)
else:
- self._EmitEventGetter(self._shared.GetParentEventsClass(self._interface))
+ parent_events_class = self._shared.GetParentEventsClass(self._interface)
+ self._EmitEventGetter('_' + parent_events_class + 'Impl')
def _EmitFactoryProvider(self, interface_name, constructor_info):
template_file = 'factoryprovider_%s.darttemplate' % interface_name
@@ -1055,10 +1056,10 @@ class HtmlFrogClassGenerator(FrogInterfaceGenerator):
else:
raise Exception('No known html even name for event: ' + event_name)
- def _EmitEventGetter(self, interface):
+ def _EmitEventGetter(self, events_class):
self._members_emitter.Emit(
'\n $TYPE get on() =>\n new $TYPE($EVENTTARGET);\n',
- TYPE=interface,
+ TYPE=events_class,
EVENTTARGET='_jsDocument' if self._interface.id == 'Document'
else 'this')
@@ -1285,7 +1286,8 @@ class HtmlDartiumInterfaceGenerator(object):
elif events:
self.AddEventAttributes(events)
else:
- self._EmitEventGetter(self._shared.GetParentEventsClass(self._interface))
+ parent_events_class = self._shared.GetParentEventsClass(self._interface)
+ self._EmitEventGetter('_' + parent_events_class + 'Impl')
def _EmitFactoryProvider(self, interface_name, constructor_info):
template_file = 'factoryprovider_%s.darttemplate' % interface_name
« no previous file with comments | « no previous file | client/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698