Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 9652030: Fix compile errors on Windows introduced by r10983. (Closed)

Created:
8 years, 9 months ago by ulan
Modified:
8 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix compile errors on Windows introduced by r10983. R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10987

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M src/date.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M test/mjsunit/date.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
Please take a look.
8 years, 9 months ago (2012-03-09 12:47:48 UTC) #1
Michael Starzinger
https://chromiumcodereview.appspot.com/9652030/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/9652030/diff/1/src/runtime.cc#newcode7574 src/runtime.cc:7574: time > DateCache::kMaxTimeBeforeUTCInMs)) { A test case for this ...
8 years, 9 months ago (2012-03-09 12:51:48 UTC) #2
Michael Starzinger
8 years, 9 months ago (2012-03-09 13:01:14 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698